Skip to content

Commit 5d0ec1e

Browse files
committed
Remove redundant conditional check
- Line 35 is the only that uses the `remove_question_group` variable. However, line 35 is only executed when `condition.nil? == true` (line 18).
1 parent dc04625 commit 5d0ec1e

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

app/views/org_admin/conditions/_form.html.erb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@
1010
action_type_arr = [["removes", :remove], ["adds notification", :add_webhook]]
1111
name_start = "conditions[#{condition_no.to_s}]"
1212
remove_question_collection = later_question_list(question)
13-
remove_question_group = condition.present? ?
14-
grouped_options_for_select(remove_question_collection, condition[:remove_question_id]) :
15-
grouped_options_for_select(remove_question_collection)
13+
remove_question_group = grouped_options_for_select(remove_question_collection)
1614
view_email_content_info = _("Hover over the email address to view email content. To change email details you need to remove and add the condition again.")
1715
%>
1816

0 commit comments

Comments
 (0)