Skip to content

Commit 865d5de

Browse files
committed
Remove plan parameter from fetch function
1 parent ccc7699 commit 865d5de

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

app/presenters/api/v2/plan_presenter.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ def identifier
3636
end
3737

3838
# Fetch all questions and answers from a plan, regardless of theme
39-
def fetch_all_q_and_a(plan:) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity
40-
return [] unless plan&.questions.present?
39+
def fetch_all_q_and_a # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity
40+
return [] unless @plan&.questions.present?
4141

42-
plan.questions.filter_map do |q|
43-
a = plan.answers.find { |ans| ans.question_id == q.id }
42+
@plan.questions.filter_map do |q|
43+
a = @plan.answers.find { |ans| ans.question_id == q.id }
4444
next unless a.present? && !a.blank?
4545

4646
{

app/views/api/v2/plans/_show.json.jbuilder

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ unless @minimal
7272
if @question_and_answer
7373
json.questions_and_answers do
7474
outputs.each do |output|
75-
q_and_a = presenter.send(:fetch_all_q_and_a, plan: plan)
75+
q_and_a = presenter.send(:fetch_all_q_and_a)
7676
next if q_and_a.blank?
7777

7878
json.set! output.id.to_s do

0 commit comments

Comments
 (0)