Added a a changes suggested by @aaronskiba in code review to remove

    rendancy and optimise code.

Author: John Pinto

app/helpers/conditions_helper.rb

@@ -23,10 +23,11 @@ def answer_remove_list(answer, user = nil)
     id_list = []
     return id_list unless answer.question.option_based?
 
+    chosen = answer.question_option_ids.sort
+
     answer.question.conditions.each do |cond|
       opts = cond.option_list.map(&:to_i).sort
       action = cond.action_type
-      chosen = answer.question_option_ids.sort
 
       # If the chosen (options) include the opts (options list) in the condition,
       # then we apply the action.

app/models/condition.rb

@@ -39,10 +39,10 @@ def deep_copy(**options)
     copy = dup
     copy.question_id = options.fetch(:question_id, nil)
     # Added to allow options to be passed in for all fields
-    copy.option_list = options.fetch(:option_list, option_list) if options.key?(:option_list)
-    copy.remove_data = options.fetch(:remove_data, remove_data) if options.key?(:remove_data)
-    copy.action_type = options.fetch(:action_type, action_type) if options.key?(:action_type)
-    copy.webhook_data = options.fetch(:webhook_data, webhook_data) if options.key?(:webhook_data)
+    copy.option_list = options[:option_list] if options.key?(:option_list)
+    copy.remove_data = options[:remove_data] if options.key?(:remove_data)
+    copy.action_type = options[:action_type] if options.key?(:action_type)
+    copy.webhook_data = options[:webhook_data] if options.key?(:webhook_data)
     # TODO: why call validate false here
     copy.save!(validate: false) if options.fetch(:save, false)
     copy