Fix invalid message property.

Author: Danial Manavi

package.json

@@ -1,6 +1,6 @@
 {
   "name": "error-lib",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "Standard Error Library for JavaScript/TypeScript projects (NodeJS & Browsers)",
   "main": "./dist/require/index.js",
   "module": "./dist/import/index.js",

src/application.error.ts

@@ -5,8 +5,11 @@ import { ErrorOptions } from './types';
  * Application Error
  */
 export class ApplicationError extends BaseError {
-  constructor(message: string, error?: Error, opts?: ErrorOptions) {
-    super(message, error, opts);
+  constructor(message?: string, error?: Error, opts?: ErrorOptions) {
+    // initialize null/undefined properties
+    const _message = message || ApplicationError.name;
+
+    super(_message, error, opts);
 
     // set stacktrace
     Error.captureStackTrace(this, ApplicationError);

src/bad_request.http.error.ts

@@ -29,8 +29,11 @@ export class HttpBadRequestError<TError = any> extends HttpError {
       opts?.statusMessage || getReasonPhrase(parentConstructorProps.statusCode);
     parentConstructorProps.isHandled = opts?.isHandled || false;
 
+    // initialize null/undefined properties
+    const _message = message || HttpBadRequestError.name;
+
     /* Call the constructor with overrided parameters */
-    super(message, error, parentConstructorProps);
+    super(_message, error, parentConstructorProps);
 
     /* Class-specific parameters */
     this.clientErrors = opts?.clientErrors || [];

src/base.error.ts

@@ -7,10 +7,13 @@ export abstract class BaseError extends Error {
   public readonly code: ErrorCodeType;
 
   constructor(message?: string, error?: Error, opts?: ErrorOptions) {
+    // initialize null/undefined properties
+    const _message = message || BaseError.name;
+
     /* Initialization phase */
-    super(message);
+    super(_message);
 
-    this.message = message || BaseError.name;
+    this.message = _message;
     this.stack = error?.stack;
     this.code = opts?.code || BaseError.name;
 

src/forbidden.http.error.ts

@@ -35,8 +35,11 @@ export class HttpForbiddenError<
       opts?.statusMessage || getReasonPhrase(parentConstructorProps.statusCode);
     parentConstructorProps.isHandled = opts?.isHandled || false;
 
+    // initialize null/undefined properties
+    const _message = message || HttpForbiddenError.name;
+
     /* Call the constructor with overridden parameters */
-    super(message, error, parentConstructorProps);
+    super(_message, error, parentConstructorProps);
 
     /* Class-specific parameters */
     this.userId = userId;

src/http.error.ts

@@ -1,6 +1,6 @@
 import statusCodes, { getReasonPhrase } from 'http-status-codes';
 
-import { BaseError } from './base.error';
+import { ApplicationError } from './application.error';
 import { ErrorOptions } from './types';
 
 export type HttpErrorOptions = ErrorOptions & {
@@ -20,8 +20,7 @@ export type HttpErrorOptions = ErrorOptions & {
   isHandled?: boolean;
 };
 
-export class HttpError extends BaseError {
-
+export class HttpError extends ApplicationError {
   /**
    * HTTP status regarding the error
    */
@@ -38,11 +37,15 @@ export class HttpError extends BaseError {
   public readonly isHandled?: boolean;
 
   constructor(message?: string, error?: Error, opts?: HttpErrorOptions) {
+    // initialize null/undefined properties
+    const _message = message || HttpError.name;
+
     /* Initialization phase */
-    super(message, error, opts);
+    super(_message, error, opts);
 
     this.statusCode = opts?.statusCode || statusCodes.INTERNAL_SERVER_ERROR;
-    this.statusMessage = opts?.statusMessage || getReasonPhrase(this.statusCode);
+    this.statusMessage =
+      opts?.statusMessage || getReasonPhrase(this.statusCode);
     this.isHandled = opts?.isHandled || false;
 
     // set stacktrace

src/missing_argument.error.ts

@@ -7,7 +7,6 @@ import { ErrorOptions } from './types';
 import { isNonEmptyString } from './util';
 
 export type MissingArgumentErrorOptions = ErrorOptions & {
-
   /**
    * Name of the argument
    */
@@ -18,19 +17,24 @@ export type MissingArgumentErrorOptions = ErrorOptions & {
  * Missing Argument Error
  */
 export class MissingArgumentError extends BaseError {
-
   /**
    * Name of the argument
    */
   public readonly argumentName: string;
 
-  constructor(message?: string, error?: Error, opts?: MissingArgumentErrorOptions) {
+  constructor(
+    message?: string,
+    error?: Error,
+    opts?: MissingArgumentErrorOptions,
+  ) {
     /* Initialization phase */
     if (isNonEmptyString(opts?.argumentName) === true) {
-      throw new Error('The \'argumentName\' needs to be a non-empty string.')
+      throw new Error("The 'argumentName' needs to be a non-empty string.");
     }
 
-    super(message || `'${opts?.argumentName}' is missing.`, error, { code: opts?.code || MissingArgumentError.name });
+    super(message || `'${opts?.argumentName}' is missing.`, error, {
+      code: opts?.code || MissingArgumentError.name,
+    });
 
     this.argumentName = opts?.argumentName!;
 

src/not_found.http.error.ts

@@ -28,8 +28,11 @@ export class HttpNotFoundError<
       opts?.statusMessage || getReasonPhrase(parentConstructorProps.statusCode);
     parentConstructorProps.isHandled = opts?.isHandled || false;
 
+    // initialize null/undefined properties
+    const _message = message || HttpNotFoundError.name;
+
     /* Call the constructor with overridden parameters */
-    super(message, error, parentConstructorProps);
+    super(_message, error, parentConstructorProps);
 
     /* Class-specific parameters */
     this.resourceType = resourceType;