refactor: rename newAPIPageSize to dnsPoliciesPageLimit

Agent-Logs-Url: https://github.com/Matthew-Kilpatrick/dnscontrol/sessions/95d5d2c0-f4e6-4337-adcb-b25aeb707c2c

Co-authored-by: Matthew-Kilpatrick <16194494+Matthew-Kilpatrick@users.noreply.github.com>

Author: Copilot

providers/unifi/api.go

@@ -245,26 +245,40 @@ func (c *unifiClient) getSiteID() (string, error) {
 	return "", fmt.Errorf("site '%s' not found", c.site)
 }
 
-// getRecordsNew fetches all DNS policy records using the NEW API.
+// dnsPoliciesPageLimit is the number of records to request per page when listing DNS policies.
+const dnsPoliciesPageLimit = 200
+
+// getRecordsNew fetches all DNS policy records using the NEW API, paginating as needed.
 func (c *unifiClient) getRecordsNew() ([]dnsPolicyRecord, error) {
 	siteID, err := c.getSiteID()
 	if err != nil {
 		return nil, err
 	}
 
-	path := fmt.Sprintf("/integration/v1/sites/%s/dns/policies", siteID)
+	var allRecords []dnsPolicyRecord
+	offset := 0
+	for {
+		path := fmt.Sprintf("/integration/v1/sites/%s/dns/policies?offset=%d&limit=%d", siteID, offset, dnsPoliciesPageLimit)
 
-	respBytes, err := c.do("GET", path, nil)
-	if err != nil {
-		return nil, fmt.Errorf("failed to fetch records: %w", err)
-	}
+		respBytes, err := c.do("GET", path, nil)
+		if err != nil {
+			return nil, fmt.Errorf("failed to fetch records: %w", err)
+		}
 
-	var response dnsPolicyResponse
-	if err := json.Unmarshal(respBytes, &response); err != nil {
-		return nil, fmt.Errorf("failed to parse records: %w", err)
+		var response dnsPolicyResponse
+		if err := json.Unmarshal(respBytes, &response); err != nil {
+			return nil, fmt.Errorf("failed to parse records: %w", err)
+		}
+
+		allRecords = append(allRecords, response.Data...)
+
+		if len(response.Data) < dnsPoliciesPageLimit {
+			break
+		}
+		offset += dnsPoliciesPageLimit
 	}
 
-	return response.Data, nil
+	return allRecords, nil
 }
 
 // createRecordNew creates a new DNS record using the NEW API.
@@ -346,7 +360,7 @@ func (c *unifiClient) detectAPIAvailability() {
 	if _, err := c.getSiteID(); err == nil {
 		// Site ID fetched successfully, try to get records
 		siteID := c.siteID
-		path := fmt.Sprintf("/integration/v1/sites/%s/dns/policies", siteID)
+		path := fmt.Sprintf("/integration/v1/sites/%s/dns/policies?limit=1", siteID)
 		if _, err := c.do("GET", path, nil); err == nil {
 			newAvailable = true
 		}