Enable DEBUG mode for preview is not working

[tjarbo]

Describe the bug
While trying to the run the preview command with the --debug flag, DNSControl prints the version number and does not perform the expected verbose preview run.

To Reproduce
Steps to reproduce the behavior:

1. Use the container image
2. Run the following commands:

➜  folder-name git:(main) ✗ docker run --rm -it -v "$(pwd):/dns:z" ghcr.io/stackexchange/dnscontrol                        
NAME:
   dnscontrol - DNSControl is a compiler and DSL for managing dns zones

USAGE:
   dnscontrol [global options] [command [command options]]

VERSION:
   DNSControl version 4.36.1

COMMANDS:
   help, h  Shows a list of commands or help for one command

   main:
     preview  read live configuration and identify changes to be made, without applying them
     push     identify changes to be made, and perform them

   debug:
     check     Check and validate dnsconfig.js. Output to stdout.  Do not access providers.
     print-ir  Output intermediate representation (IR) after running validation and normalization logic.
     version   Print version information

   utility:
     check-creds          Do a small operation to verify credentials (stand-alone)
     create-domains       DEPRECATED: Ensures that all domains in your configuration are activated at their Domain Service Provider (This does not purchase the domain or otherwise interact with Registrars.)
     fmt                  [BETA] Format and prettify a given file
     get-zones, get-zone  gets a zone from a provider (stand-alone)
     shell-completion     generate shell completion scripts
     write-types          [BETA] Write a TypeScript declaration file in the current directory

GLOBAL OPTIONS:
   --debug, -v        Enable debug logging
   --allow-fetch      Enable JS fetch(), dangerous on untrusted code!
   --disableordering  Disables update reordering
   --no-colors        Disable colors
   --help, -h         show help
   --version, -v      print the version
➜  folder-name git:(main) ✗ docker run --rm -it -v "$(pwd):/dns:z" ghcr.io/stackexchange/dnscontrol --debug preview
dnscontrol version DNSControl version 4.36.1
➜  folder-name git:(main) ✗ docker run --rm -it -v "$(pwd):/dns:z" ghcr.io/stackexchange/dnscontrol -v preview     
dnscontrol version DNSControl version 4.36.1
➜  folder-name git:(main) ✗ docker run --rm -it -v "$(pwd):/dns:z" ghcr.io/stackexchange/dnscontrol preview   
CONCURRENTLY checking for 1 zone(s)
SERIALLY checking for 0 zone(s)
Waiting for concurrent checking(s) to complete...DONE
[...]

Expected behavior
A normal preview run with more details.

Additional context
The document https://github.com/DNSControl/dnscontrol/blob/main/documentation/commands/globalflags.md describes, that the --debug flag has to be placed before the preview command.
As visible in the help menu of the first command, --debug and --version share the same alias -v.

[TomOnTime]

Hello friend!

Thank you for reporting this. I have a hunch this was fixed in #4141 (bug #4138). I don't think the code has made it into a release yet.

There hasn't been a new release in a few weeks due to the transition of DNSControl to being an independent project (#4174). New releases should start flowing soon.

[tjarbo]

Hi!

Thanks for your quick response! I have to admit that I totally forgot to check the discussions panel.
It looks indeed that #4141 should solve the issue.
I would suggest keeping the issue open for tracking and either I or whoever is faster than me will close it if we can confirm the fix with the next release.

Best regards

[TomOnTime]

#4141 shipped. Please confirm this fixes the bug.

[tjarbo]

I will have a look and keep you posted.

[tjarbo]

Works as expected now - thanks a lot!