BUGFIX: Remove PORKBUN_URLFWD since it's an alias to URL and URL301#4419
Closed
TomOnTime wants to merge 6 commits into
Closed
BUGFIX: Remove PORKBUN_URLFWD since it's an alias to URL and URL301#4419TomOnTime wants to merge 6 commits into
TomOnTime wants to merge 6 commits into
Conversation
## Summary Register `CredsMetadata` for CLOUDNS so the provider is offered by the `dnscontrol init` wizard. Fields mirror the entries in `integrationTest/profiles.json`. CC: @pragmaton ## Test plan - [ ] `go build ./...` passes - [ ] `dnscontrol init` lists CLOUDNS as an option - [ ] Verify any `// TODO: Verify` annotations in the diff (e.g. `PortalURL`) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
<!--
## Before submiting a pull request
Please make sure you've run the following commands from the root
directory.
bin/generate-all.sh
(this runs commands like "go generate", fixes formatting, and so on)
## Release changelog section
Help keep the release changelog clear by pre-naming the proper section
in the GitHub pull request title.
Some examples:
* CICD: Add required GHA permissions for goreleaser
* DOCS: Fixed providers with "contributor support" table
* ROUTE53: Allow R53_ALIAS records to enable target health evaluation
More examples/context can be found in the file .goreleaser.yml under the
'build' > 'changelog' key.
!-->
Manually tested locally and LGTM.
Codex was used.
…As (#4417) This PR adds validations to reject multipel SOA records. Also unit tests for new function checkMultipleSOAs added. I did run integration tests only for Route 53 but there isn't anything Route 53 provider spesific.
TomOnTime
changed the title
Member
Yes, this is what I want to do yesterday. But today I noticed porkbun has third type of url forwarding named This type can be only created in web dashboard, no description in API docs at all, but listing in getUrlForwarding API response. I'm asking support about it. If we want to support this type I think we need to keep the PORKBUN_URLFWD. Sorry for the back and forth.
It will need a domain register with them, so not now, just ping me when test needed. |
Collaborator
Author
|
I'm not sure I understand. Would you like to make a PR instead? |
Member
|
I will make a PR in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
According to #4414 (comment)
We can remove PORKBUN_URLFWD since it's an alias to URL and URL301 (as of #3951)
Resolution
Remove PORKBUN_URLFWD and related tests.
CC imlonghao (Please let me know if this works. Also... I've removed everything related to urlfwd. Is that what you were suggesting or did I go too far?)
By the way... we could avoid this kind of breakage if I had a test account for Porkbun. That way the GHA tests would test porkbun with every PR. Is that something you can arrange? It can be a free/test account, or just an API key locked to a domain/zone that you've set up. Details are here: https://docs.dnscontrol.org/developer-info/byo-secrets Thanks for considering that!