Try to delete EventLog key

- Don`t know why it`s there on some systems?

Author: bitbeans

SimpleDnsCrypt/Helper/DnsCryptProxyManager.cs

@@ -3,10 +3,12 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
+using System.Security.AccessControl;
 using System.ServiceProcess;
 using System.Text;
 using System.Threading;
 using Caliburn.Micro;
+using Microsoft.Win32;
 using Nett;
 using Newtonsoft.Json;
 using SimpleDnsCrypt.Config;
@@ -267,7 +269,27 @@ public static List<AvailableResolver> GetAllResolversWithFilters()
 		public static bool Install()
 		{
 			var result = ExecuteWithArguments("-service install");
-			return result.Success;
+			if (result.Success)
+			{
+				return true;
+			}
+
+			try
+			{
+				if (string.IsNullOrEmpty(result.StandardError)) return false;
+				if (result.StandardError.Contains("SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\dnscrypt-proxy"))
+				{
+					Registry.LocalMachine.DeleteSubKey(@"SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy",
+						false);
+					return Install();
+				}
+			}
+			catch (Exception exception)
+			{
+				Log.Error(exception);
+			}
+
+			return false;
 		}
 
 		/// <summary>
@@ -277,6 +299,21 @@ public static bool Install()
 		public static bool Uninstall()
 		{
 			var result = ExecuteWithArguments("-service uninstall");
+			try
+			{
+				var eventLogKey = Registry.LocalMachine.OpenSubKey(@"SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy",
+					RegistryRights.ReadKey);
+				var eventLogKeyValue = eventLogKey?.GetValue("CustomSource");
+				if (eventLogKeyValue != null)
+				{
+					Registry.LocalMachine.DeleteSubKey(@"SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy", false);
+				}
+			}
+			catch (Exception exception)
+			{
+				Log.Error(exception);
+			}
+
 			return result.Success;
 		}
 

SimpleDnsCrypt/ViewModels/MainViewModel.cs

@@ -623,7 +623,10 @@ public void OpenLogDirectory()
 			try
 			{
 				var logDirectory = Path.Combine(Directory.GetCurrentDirectory(), "logs");
-				Process.Start(logDirectory);
+				if (Directory.Exists(logDirectory))
+				{
+					Process.Start(logDirectory);
+				}
 			}
 			catch (Exception exception)
 			{
@@ -649,8 +652,8 @@ public void SaveLocalServers()
 			}
 			else
 			{
-				//TODO: translate
-				_windowManager.ShowMetroMessageBox("At least one server must be selected. Otherwise, dnscrypt-proxy uses all servers corresponding to the selected filters.", "No server selected",
+				_windowManager.ShowMetroMessageBox(LocalizationEx.GetUiString("message_content_no_server_selected", Thread.CurrentThread.CurrentCulture),
+					LocalizationEx.GetUiString("message_title_no_server_selected", Thread.CurrentThread.CurrentCulture),
 					MessageBoxButton.OK, BoxType.Warning);
 			}
 		}

Uninstall/Program.cs

@@ -4,6 +4,7 @@
 using System.IO;
 using System.Net.NetworkInformation;
 using System.Threading;
+using Microsoft.Win32;
 
 namespace Uninstall
 {
@@ -40,6 +41,7 @@ internal static void UninstallService()
 		{
 			Console.WriteLine("removing dnscrypt service");
 			ExecuteWithArguments("-service uninstall");
+			Registry.LocalMachine.DeleteSubKey(@"SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy", false);
 		}
 
 		/// <summary>

Uninstall/Properties/AssemblyInfo.cs

@@ -11,5 +11,5 @@
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
 [assembly: Guid("1a9ca4fe-bdd5-4d7c-a86a-7ed503974718")]
-[assembly: AssemblyVersion("0.2.1")]
-[assembly: AssemblyFileVersion("0.2.1")]
+[assembly: AssemblyVersion("0.2.2")]
+[assembly: AssemblyFileVersion("0.2.2")]