Improve error message on DNSSEC failure

jedisct1 · jedisct1 · commit 70311614a022 · 2020-01-31T10:58:07.000+01:00
diff --git a/dnscrypt-proxy/proxy.go b/dnscrypt-proxy/proxy.go
@@ -569,8 +569,12 @@ func (proxy *Proxy) processIncomingQuery(serverInfo *ServerInfo, clientProto str
 			}
 		}
 		if rcode := Rcode(response); rcode == dns.RcodeServerFailure { // SERVFAIL
-			dlog.Infof("Server [%v] returned temporary error code [%v] -- Upstream server may be experiencing connectivity issues", serverInfo.Name, rcode)
-			serverInfo.noticeFailure(proxy)
+			if pluginsState.dnssec {
+				dlog.Debug("A response had an invalid DNSSEC signature")
+			} else {
+				dlog.Infof("Server [%v] returned temporary error code SERVFAIL -- Invalid DNSSEC signature received or server may be experiencing connectivity issues", serverInfo.Name)
+				serverInfo.noticeFailure(proxy)
+			}
 		} else {
 			serverInfo.noticeSuccess(proxy)
 		}

Original file line number	Diff line number	Diff line change
`@@ -569,8 +569,12 @@ func (proxy Proxy) processIncomingQuery(serverInfo ServerInfo, clientProto str`
`569`	`569`	`}`
`570`	`570`	`}`
`571`	`571`	`if rcode := Rcode(response); rcode == dns.RcodeServerFailure { // SERVFAIL`
`572`		`- dlog.Infof("Server [%v] returned temporary error code [%v] -- Upstream server may be experiencing connectivity issues", serverInfo.Name, rcode)`
`573`		`- serverInfo.noticeFailure(proxy)`
	`572`	`+ if pluginsState.dnssec {`
	`573`	`+ dlog.Debug("A response had an invalid DNSSEC signature")`
	`574`	`+ } else {`
	`575`	`+ dlog.Infof("Server [%v] returned temporary error code SERVFAIL -- Invalid DNSSEC signature received or server may be experiencing connectivity issues", serverInfo.Name)`
	`576`	`+ serverInfo.noticeFailure(proxy)`
	`577`	`+ }`
`574`	`578`	`} else {`
`575`	`579`	`serverInfo.noticeSuccess(proxy)`
`576`	`580`	`}`