Correctly fix #2973

jedisct1 · jedisct1 · commit af6c4f8c1562 · 2025-09-22T23:04:30.000+02:00
diff --git a/dnscrypt-proxy/xtransport.go b/dnscrypt-proxy/xtransport.go
@@ -321,10 +321,10 @@ func (xTransport *XTransport) rebuildTransport() {
 			tlsCfg.ServerName = host
 			conn, err := quic.DialEarly(ctx, udpConn, udpAddr, tlsCfg, cfg)
 			if err != nil {
-				conn.Close()
+				udpConn.Close()
 				return nil, err
 			}
-			return conn, err
+			return conn, nil
 		}
 		h3Transport := &http3.Transport{DisableCompression: true, TLSClientConfig: &tlsClientConfig, Dial: dial}
 		xTransport.h3Transport = h3Transport

Original file line number	Diff line number	Diff line change
`@@ -321,10 +321,10 @@ func (xTransport *XTransport) rebuildTransport() {`
`321`	`321`	`tlsCfg.ServerName = host`
`322`	`322`	`conn, err := quic.DialEarly(ctx, udpConn, udpAddr, tlsCfg, cfg)`
`323`	`323`	`if err != nil {`
`324`		`- conn.Close()`
	`324`	`+ udpConn.Close()`
`325`	`325`	`return nil, err`
`326`	`326`	`}`
`327`		`- return conn, err`
	`327`	`+ return conn, nil`
`328`	`328`	`}`
`329`	`329`	`h3Transport := &http3.Transport{DisableCompression: true, TLSClientConfig: &tlsClientConfig, Dial: dial}`
`330`	`330`	`xTransport.h3Transport = h3Transport`