improve (stabilize) server rtt computation#2888
Closed
Conversation
prevent sporadic outliers from heavily affecting the server rtt e.g. the new scoring system stops considering the server rtt when it's over 1s: just because a fast server has 2 slow responses in a row shouldn't put it in the bad server category on the other hand this change still allows to adapt to actual slowdowns quite quickly
Member
|
Instead of magic constants, maybe define something like const (
RTTEwmaDecay = 20.0
RTTOutlierUpperBound = 10.0
RTTOutlierLowerBound = 0.1
)Also, indentation is funky. |
ghost
marked this pull request as draft
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent sporadic outliers from heavily affecting the server rtt
e.g. the new scoring system stops considering the server rtt when it's over 1s: just because a fast server has 2 slow responses in a row shouldn't put it in the bad server category
on the other hand this change still allows to adapt to actual slowdowns quite quickly