Merge pull request #2389 from jwillemsen/jwi-vs2022bug

Add new compiler test to reproduce issue

Author: jwillemsen

ACE/tests/Compiler_Features_42_Test.cpp

@@ -0,0 +1,42 @@
+/**
+ * This program reproduces an compiler issue with Visual Studio 2022
+ */
+
+#include "test_config.h"
+#include <array>
+#include <string>
+
+namespace Test
+{
+  using arrayofstring = std::array<std::string, 5>;
+
+  class unionarrayofstring
+  {
+  public:
+    unionarrayofstring () = default;
+    unionarrayofstring (const unionarrayofstring&) = delete;
+    unionarrayofstring (unionarrayofstring&&) = delete;
+    inline ~unionarrayofstring () {}
+    unionarrayofstring& operator= (const unionarrayofstring&) = delete;
+    unionarrayofstring& operator= (unionarrayofstring&&) = delete;
+
+  private:
+    union u_type_
+    {
+      u_type_ () = default;
+      ~u_type_ () {}
+      ::Test::arrayofstring as_{};
+    } u_{};
+  };
+}
+
+int run_main (int, ACE_TCHAR*[])
+{
+  ACE_START_TEST (ACE_TEXT ("Compiler_Features_42_Test"));
+
+  ::Test::unionarrayofstring p;
+
+  ACE_END_TEST;
+
+  return 0;
+}

ACE/tests/run_test.lst

@@ -112,6 +112,7 @@ Compiler_Features_38_Test
 Compiler_Features_39_Test
 Compiler_Features_40_Test
 Compiler_Features_41_Test
+Compiler_Features_42_Test
 Config_Test: !LynxOS !VxWorks !ACE_FOR_TAO
 Conn_Test: !ACE_FOR_TAO
 DLL_Test: !STATIC

ACE/tests/tests.mpc

@@ -863,6 +863,17 @@ project(Compiler_Features_41_Test) : acetest {
   }
 }
 
+project(Compiler_Features_42_Test) : acetest {
+  exename = Compiler_Features_42_Test
+  Source_Files {
+    Compiler_Features_42_Test.cpp
+  }
+  // Visual Studio 2019/2022 give an internal compiler error when using C++17 (the default for ACE)
+  specific(vs2019,vs2022) {
+    LanguageStandard = stdcpp20
+  }
+}
+
 project(Config Test) : acetest {
   avoids += ace_for_tao
   exename = Config_Test

TAO/tao/AnyTypeCode/TypeCode_Case_T.h

@@ -36,8 +36,7 @@ namespace TAO
      *
      * A @c Case_T contains the corresponding case label value, name and
      * pointer to the @c CORBA::TypeCode for a given OMG IDL @c union
-     * @c case.  For
-     * example, the cases in following OMG IDL @c union:
+     * @c case.  For example, the cases in following OMG IDL @c union:
      *
      * \code
      *   union Foo switch (short)