Time_Value & Floating-point std::chrono::duration

`ACE_Time_Value` currently doesn't accept a `std::chrono::duration` with
`Rep` that's a floating point type because it's using the modulus
operator to separate the microseconds (`duration % seconds(1)`) and
trying to use modulus with floating points causes a compile error.

This changes it to use subtraction from the whole number of seconds
(`duration - sec`) and adds a test for it.

Author: iguessthislldo

ACE/ace/Time_Value.h

@@ -118,13 +118,11 @@ class ACE_Export ACE_Time_Value
   template< class Rep, class Period >
   void set (const std::chrono::duration<Rep, Period>& duration)
   {
-    std::chrono::seconds const s {
-      std::chrono::duration_cast<std::chrono::seconds> (duration)};
+    using namespace std::chrono;
 
-    std::chrono::microseconds const usec {
-      std::chrono::duration_cast<std::chrono::microseconds>(
-        duration % std::chrono::seconds (1))};
-    this->set (ACE_Utils::truncate_cast<time_t>(s.count ()), ACE_Utils::truncate_cast<suseconds_t>(usec.count ()));
+    seconds const sec {duration_cast<seconds> (duration)};
+    microseconds const usec {duration_cast<microseconds> (duration  - sec)};
+    this->set (ACE_Utils::truncate_cast<time_t> (sec.count ()), ACE_Utils::truncate_cast<suseconds_t> (usec.count ()));
   }
 
   /// Converts from ACE_Time_Value format into milliseconds format.

ACE/tests/.gitignore

@@ -94,6 +94,13 @@
 /Compiler_Features_33_Test
 /Compiler_Features_34_Test
 /Compiler_Features_35_Test
+/Compiler_Features_36_Test
+/Compiler_Features_37_Test
+/Compiler_Features_38_Test
+/Compiler_Features_39_Test
+/Compiler_Features_40_Test
+/Compiler_Features_41_Test
+/Compiler_Features_42_Test
 /Config_Test
 /Conn_Test
 /Date_Time_Test
@@ -110,6 +117,7 @@
 /FlReactor_Test
 /Framework_Component_Test
 /Future_Set_Test
+/Future_Stress_Test
 /Future_Test
 /Get_Opt_Test
 /Handle_Set_Test
@@ -152,6 +160,7 @@
 /MT_Reference_Counted_Event_Handler_Test
 /MT_Reference_Counted_Notify_Test
 /MT_SOCK_Test
+/Multicast_Interfaces_Test
 /Multicast_Test
 /Multicast_Test_IPV6
 /Multihomed_INET_Addr_Test
@@ -216,8 +225,9 @@
 /Signal_Test
 /Sigset_Ops_Test
 /Simple_Message_Block_Test
-/Singleton_Test
 /Singleton_Restart_Test
+/Singleton_Test
+/SOCK_Acceptor_Test
 /SOCK_Connector_Test
 /SOCK_Dgram_Bcast_Test
 /SOCK_Dgram_Test
@@ -256,8 +266,8 @@
 /Token_Strategy_Test
 /Tokens_Test
 /TP_Reactor_Test
-/TSS_Static_Test
 /TSS_Leak_Test
+/TSS_Static_Test
 /TSS_Test
 /Unbounded_Set_Test
 /Unbounded_Set_Test_Ex
@@ -273,8 +283,3 @@
 /XtAthenaReactor_Test
 /XtMotifReactor_Test
 /XtReactor_Test
-/Compiler_Features_36_Test
-/Compiler_Features_37_Test
-/Compiler_Features_38_Test
-/SOCK_Acceptor_Test
-Multicast_Interfaces_Test

ACE/tests/Chrono_Test.cpp

@@ -144,9 +144,21 @@ test_assignments ()
     ++errors;
   }
 
+  // ACE_Time_Value should accept floating-point-based durations.
+  std::chrono::duration<double, std::ratio<(24*3600)>> const half_day {0.5};
+  tv = ACE_Time_Value { half_day };
+  if (tv.sec () != 3600*12 || tv.usec () != 0)
+  {
+    ACE_ERROR ((LM_ERROR,
+                ACE_TEXT ("(%P|%t) unexpected value after converting ")
+                ACE_TEXT ("duration<double, std::ratio<(24*3600)>> to an ACE_Time_Value. ")
+                ACE_TEXT ("<sec=%d,usec=0> - got <sec=%d,usec=%d>\n"),
+                3600*12, tv.sec (), tv.usec ()));
+    ++errors;
+  }
+
   // Two times half a day, 3 hours, 24 minutes, 54 seconds, 238 milliseconds,
   // 754 microseconds and 342 nanoseconds.
-  std::chrono::duration<double, std::ratio<(24*3600)>> half_day {0.5};
   std::chrono::microseconds const usec {
     2 * (
     std::chrono::duration_cast<std::chrono::microseconds> (