Added conditional compilation for SetThreadDescription

mitza-oci · mitza-oci · commit 7b2999841aaf · 2025-08-07T11:35:30.000-05:00
Older versions of Windows don't support SetThreadDescription.
When building an ACE library that needs to be compatible with these,
set ACE_LACKS_SETTHREADDESCRIPTION in config.h.

This can't be determined from the Windows headers which
include SetThreadDescription unconditionally.
diff --git a/ACE/ace/OS_NS_Thread.cpp b/ACE/ace/OS_NS_Thread.cpp
@@ -4113,10 +4113,12 @@ ACE_OS::thr_create (ACE_THR_FUNC func,
                                                 flags,
                                                 thr_id);
 
+#   ifndef ACE_LACKS_SETTHREADDESCRIPTION
       if (thr_name && *thr_name && *thr_handle)
         {
           SetThreadDescription (*thr_handle, ACE_Ascii_To_Wide (*thr_name).wchar_rep ());
         }
+#   endif
 
       if (priority != ACE_DEFAULT_THREAD_PRIORITY && *thr_handle != 0)
         {

Original file line number	Diff line number	Diff line change
`@@ -4113,10 +4113,12 @@ ACE_OS::thr_create (ACE_THR_FUNC func,`
`4113`	`4113`	`flags,`
`4114`	`4114`	`thr_id);`
`4115`	`4115`
	`4116`	`+# ifndef ACE_LACKS_SETTHREADDESCRIPTION`
`4116`	`4117`	`if (thr_name && thr_name && thr_handle)`
`4117`	`4118`	`{`
`4118`	`4119`	`SetThreadDescription (thr_handle, ACE_Ascii_To_Wide (thr_name).wchar_rep ());`
`4119`	`4120`	`}`
	`4121`	`+# endif`
`4120`	`4122`
`4121`	`4123`	`if (priority != ACE_DEFAULT_THREAD_PRIORITY && *thr_handle != 0)`
`4122`	`4124`	`{`