Support for deprecated CPP_LOCATION environment variable has been removed#2387
Conversation
* TAO/TAO_IDL/fe/fe_init.cpp:
* TAO/docs/compiler.html:
* TAO/NEWS:
|
Warning Rate limit exceeded@jwillemsen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 24 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
## Walkthrough
Support for the deprecated `CPP_LOCATION` and `TAO_IDL_DEFAULT_CPP_FLAGS` environment variables has been fully removed from the TAO codebase, documentation, and release notes. The code no longer checks or warns about these variables, and related documentation and release note entries have been updated to reflect this change.
## Changes
| File(s) | Change Summary |
|-------------------------------|-----------------------------------------------------------------------------------------------------------------|
| TAO/NEWS | Updated release notes to mention removal of `CPP_LOCATION` and `TAO_IDL_DEFAULT_CPP_FLAGS` support. |
| TAO/TAO_IDL/fe/fe_init.cpp | Removed code checking and warning about the `CPP_LOCATION` and `TAO_IDL_DEFAULT_CPP_FLAGS` environment variables.|
| TAO/docs/compiler.html | Removed documentation of `CPP_LOCATION` and `TAO_IDL_DEFAULT_CPP_FLAGS` and related deprecated environment warnings.|
## Poem
> The old `CPP_LOCATION` has hopped away,
> Along with flags that once held sway.
> No warnings now in TAO's land,
> Cleaner code at our command.
> Docs and notes all say goodbye,
> A lighter path beneath the sky.
> 🐇✨Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* TAO/NEWS:
* TAO/TAO_IDL/fe/fe_init.cpp:
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
TAO/NEWS (1)
10-10: Use imperative style for NEWS entry
To align with other bullets (which begin with a past-tense verb), please update this line to start with “Removed” instead of a nominal clause.- . Support for deprecated CPP_LOCATION environment variable has been removed + . Removed support for the deprecated `CPP_LOCATION` environment variable
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
TAO/NEWS(1 hunks)TAO/TAO_IDL/fe/fe_init.cpp(1 hunks)TAO/docs/compiler.html(0 hunks)
💤 Files with no reviewable changes (1)
- TAO/docs/compiler.html
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
🔇 Additional comments (1)
TAO/TAO_IDL/fe/fe_init.cpp (1)
488-509: Clean removal of deprecated CPP_LOCATION support.The simplification of the fallback logic to use only
idl_global->cpp_location()correctly removes support for the deprecatedCPP_LOCATIONenvironment variable while preserving the intended functionality. The function maintains its primary purpose of checking forTAO_IDL_PREPROCESSORfirst, then falling back to the default location.
* TAO/NEWS:
1 participant
Summary by CodeRabbit
Documentation
Chores