TAO_IDL updates for maps

[mitza-oci]

Summary by CodeRabbit

• New Features

  • Added support for handling map types in argument lists, improving compatibility with map data structures.

• Bug Fixes

  • Removed dead code from generated files when using IDL map

[coderabbitai]

Walkthrough

Support for visiting be_map nodes was added to the be_visitor_args_arglist class, including a new method in both its header and implementation. Additionally, unreachable return false; statements after exception throws were removed from generated CDR operator functions for map types. The GitHub Actions workflows were updated to replace Visual Studio 2019 with Visual Studio 2022 and switch Windows runners from 2019 to 2022. No other logic or interface changes were made.

Changes

File(s)	Change Summary
TAO/TAO_IDL/be/be_visitor_argument/arglist.cpp	Added visit_map(be_map *node) method to handle map type arguments in argument lists.
TAO/TAO_IDL/be_include/be_visitor_argument/arglist.h	Declared new virtual method visit_map(be_map *node) in be_visitor_args_arglist class.
TAO/TAO_IDL/be/be_visitor_map/cdr_op_cs.cpp	Removed redundant return false; after throw ::CORBA::NO_IMPLEMENT(); in map CDR operators.
.github/workflows/windows.yml	Updated Windows GitHub Actions workflow to use Visual Studio 2022 and Windows 2022 runner.
.github/workflows/cmake.yml	Updated CMake GitHub Actions workflow to use Visual Studio 2022 and Windows 2022 runner.

Poem

In the warren of code, a map hops in,
Arguments now know where to begin.
No more returns after a wild throw,
Just cleaner paths for data to flow.
With every new visit, the garden expands,
As bunny engineers lend helping hands!
🗺️🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 404ea21 and 53ebda6.

📒 Files selected for processing (2)

• .github/workflows/cmake.yml (1 hunks)
• .github/workflows/windows.yml (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• .github/workflows/cmake.yml

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/windows.yml

⏰ Context from checks skipped due to timeout of 90000ms (21)

• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-24.04 g++-13
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: macos-14-C++
• GitHub Check: macos-13-C++
• GitHub Check: alpine-3.18
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: VS2022Release64
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022Release32
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Debug64Cxx17
• GitHub Check: VS2022Debug64Cxx20
• GitHub Check: VS2022Debug32
• GitHub Check: MINGW64-gcc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36cf075 and a471bf5.

📒 Files selected for processing (3)

• TAO/TAO_IDL/be/be_visitor_argument/arglist.cpp (2 hunks)
• TAO/TAO_IDL/be/be_visitor_map/cdr_op_cs.cpp (1 hunks)
• TAO/TAO_IDL/be_include/be_visitor_argument/arglist.h (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

TAO/TAO_IDL/be/be_visitor_argument/arglist.cpp (1)

TAO/TAO_IDL/be_include/be_visitor_argument/arglist.h (16)

• node (41-41)
• node (46-46)
• node (49-49)
• node (52-52)
• node (55-55)
• node (58-58)
• node (61-61)
• node (64-64)
• node (67-67)
• node (70-70)
• node (73-73)
• node (76-76)
• node (79-79)
• node (82-82)
• node (85-85)
• node (88-88)

⏰ Context from checks skipped due to timeout of 90000ms (21)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: alpine-3.18
• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: ubuntu-24.04 g++
• GitHub Check: ubuntu-24.04 g++-10 ACE for TAO
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-24.04 clang++-15
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
• GitHub Check: ubuntu-22.04 clang++-12
• GitHub Check: VS2022WChar
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022Release64
• GitHub Check: macos-13-C++
• GitHub Check: macos-14-C++

🔇 Additional comments (3)

TAO/TAO_IDL/be/be_visitor_map/cdr_op_cs.cpp (1)

60-60: LGTM: Dead code removal after throw statements

Removing the unreachable return false; statements after throw ::CORBA::NO_IMPLEMENT (); is correct cleanup. Since exceptions transfer control immediately, any code following the throw statement would be unreachable dead code.

Also applies to: 68-68

TAO/TAO_IDL/be_include/be_visitor_argument/arglist.h (1)

102-102: LGTM: Visitor pattern extension

The addition of visit_map method declaration properly extends the visitor interface to support map types, following the same pattern as other visitor methods in the class.

TAO/TAO_IDL/be/be_visitor_argument/arglist.cpp (1)

14-14: LGTM: Required include for map support

Adding the be_map.h include is necessary to support the new visit_map method implementation.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a471bf5 and 404ea21.

📒 Files selected for processing (1)

• .github/workflows/windows.yml (2 hunks)

🧰 Additional context used

🪛 YAMLlint (1.37.1)

.github/workflows/windows.yml

[error] 29-29: syntax error: expected , but found ''

(syntax)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
• GitHub Check: ubuntu-24.04 clang++-16
• GitHub Check: ubuntu-24.04 clang++-15
• GitHub Check: ubuntu-24.04 g++-10 ACE for TAO
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-22.04 clang++-12
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-24.04 g++-13
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: macos-13-C++
• GitHub Check: macos-14-C++
• GitHub Check: alpine-3.18

🔇 Additional comments (5)

.github/workflows/windows.yml (5)

20-23: Update MSVC WChar job to VS2022
Switching the VM image from windows-2019 to windows-2022 and updating mpctype to vs2022 for the VS2022WChar matrix entry ensures this job uses the latest Visual Studio toolset.

---

37-39: Update MSVC Release32 job to VS2022
The Release32 matrix entry is correctly migrated to windows-2022 and vs2022, matching the rest of the VS2022 jobs.

---

45-47: Update MSVC Debug64 C++17 job to VS2022
The C++17 debug matrix entry now correctly uses windows-2022 and vs2022.

---

54-56: Update MSVC Debug64 C++20 job to VS2022
The C++20 debug matrix entry is updated to windows-2022/vs2022, ensuring consistency.

---

159-159: Mingw job runner update
Shifting the MinGW job’s runs-on to windows-2022 brings it in line with the MSVC jobs’ environment.