Updates for Visual C++ CI and C++20 compatibility#2390
Merged
Conversation
Contributor
|
""" WalkthroughThe updates transition GitHub Actions workflows for Windows builds from Visual Studio 2019 on Windows Server 2019 to Visual Studio 2022 on Windows Server 2022, adjusting runner images and environment variables accordingly. Additionally, the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant WindowsRunner
participant BuildScript
GitHubActions->>WindowsRunner: Start workflow (VS2022, windows-2022)
WindowsRunner->>BuildScript: Set up environment (VS2022)
BuildScript->>BuildScript: Run build and tests
WindowsRunner-->>GitHubActions: Report results
sequenceDiagram
participant EndpointA as TAO_SSLIOP_Endpoint (A)
participant EndpointB as TAO_SSLIOP_Endpoint (B)
EndpointA->>EndpointB: Call is_equivalent(B)
EndpointA->>EndpointB: Check credentials_ and credentials() for null
EndpointA->>EndpointB: Compare credentials_ with credentials() (with static_cast)
EndpointA-->>EndpointB: Return true/false
Poem
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
sonndinh
previously approved these changes
Jun 4, 2025
jwillemsen
reviewed
Jun 4, 2025
mitza-oci
added a commit
to mitza-oci/ACE_TAO
that referenced
this pull request
Jun 6, 2025
Updates for Visual C++ CI and C++20 compatibility # Conflicts: # .github/workflows/cmake.yml # .github/workflows/windows.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.