Fixed compiler warnings, use default/override

[jwillemsen]

* ACE/protocols/ace/HTBP/HTBP_Addr.cpp:
* ACE/protocols/ace/HTBP/HTBP_Addr.h:

Summary by CodeRabbit

• Refactor

  • Improved internal handling of address-related objects for better consistency and maintainability.
  • Enhanced code clarity by updating method declarations and ensuring proper overrides.
  • Corrected parameter naming for address family in address parsing functions.

• Style

  • Standardized special member function declarations and destructor overrides for improved code readability.

[coderabbitai]

Walkthrough

The changes remove the explicit copy constructor implementation from the source file and replace the user-declared copy constructor in the header with a defaulted one. Additional defaulted special member functions are added, and override specifiers are applied to the destructor and two methods to clarify inheritance behavior. A parameter name typo is corrected.

Changes

File(s)	Change Summary
.../HTBP_Addr.cpp	Removed the explicit copy constructor implementation for ACE::HTBP::Addr.
.../HTBP_Addr.h	Defaulted copy/move constructors and assignment operators; updated destructor and methods with override; fixed parameter name typo.

Poem

In the warren of code, constructors hop away,
Defaulted and overridden, they brighten the day.
With special moves and copies, so clear and neat,
The Addr class now skips with lighter feet.
Override, default—let the rabbits cheer,
For tidy code is always dear!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19c4722 and ea53d39.

📒 Files selected for processing (1)

• ACE/protocols/ace/HTBP/HTBP_Addr.h (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ACE/protocols/ace/HTBP/HTBP_Addr.h

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-22.04 clang++-12
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: VS2022Release64
• GitHub Check: VS2022Debug64Cxx20
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022Release32
• GitHub Check: VS2022Debug32
• GitHub Check: VS2022Debug64Cxx17
• GitHub Check: VS2022WChar
• GitHub Check: MINGW64-gcc
• GitHub Check: ubuntu-24.04 g++
• GitHub Check: macos-13-C++
• GitHub Check: macos-14-C++
• GitHub Check: alpine-3.18
• GitHub Check: windows-2022 vs2022
• GitHub Check: ubuntu-22.04 g++-12

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1eaca90 and 19c4722.

📒 Files selected for processing (2)

• ACE/protocols/ace/HTBP/HTBP_Addr.cpp (0 hunks)
• ACE/protocols/ace/HTBP/HTBP_Addr.h (3 hunks)

💤 Files with no reviewable changes (1)

• ACE/protocols/ace/HTBP/HTBP_Addr.cpp

⏰ Context from checks skipped due to timeout of 90000ms (21)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: macos-14-C++
• GitHub Check: VS2022WChar
• GitHub Check: ubuntu-24.04 g++
• GitHub Check: ubuntu-24.04 g++-10 CodeQL
• GitHub Check: VS2022WChar
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
• GitHub Check: ubuntu-24.04 g++-10 ACE for TAO
• GitHub Check: VS2022Release32
• GitHub Check: ubuntu-24.04 g++-10 wchar
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: MINGW64-gcc
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-22.04 g++-12
• GitHub Check: windows-2022 vs2022
• GitHub Check: alpine-3.18

🔇 Additional comments (3)

ACE/protocols/ace/HTBP/HTBP_Addr.h (3)

46-49: LGTM: Explicit defaulting of special member functions.

Following the Rule of Five by explicitly defaulting the copy/move constructors and assignment operators is excellent practice. This addresses compiler warnings while making the intent clear and ensuring proper inheritance behavior.

---

64-64: LGTM: Proper use of override specifier on destructor.

Adding the override specifier to the destructor correctly indicates that this overrides a virtual destructor from the base class, improving code clarity and helping catch potential inheritance issues.

---

74-74: LGTM: Proper use of override specifier.

Adding the override specifier correctly indicates this method overrides a virtual function from the base class.