From 19c4722560326746a770b5682027c0b2991cb23f Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 6 Jun 2025 11:50:48 +0200 Subject: [PATCH 1/2] Fixed compiler warnings, use default/override * ACE/protocols/ace/HTBP/HTBP_Addr.cpp: * ACE/protocols/ace/HTBP/HTBP_Addr.h: --- ACE/protocols/ace/HTBP/HTBP_Addr.cpp | 6 ------ ACE/protocols/ace/HTBP/HTBP_Addr.h | 11 +++++++---- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/ACE/protocols/ace/HTBP/HTBP_Addr.cpp b/ACE/protocols/ace/HTBP/HTBP_Addr.cpp index 182fa4f1fbce3..e66294965463e 100644 --- a/ACE/protocols/ace/HTBP/HTBP_Addr.cpp +++ b/ACE/protocols/ace/HTBP/HTBP_Addr.cpp @@ -18,12 +18,6 @@ ACE::HTBP::Addr::Addr (const char *htid) { } -ACE::HTBP::Addr::Addr (const ACE::HTBP::Addr &other) - : ACE_INET_Addr (other), - htid_(other.htid_) -{ -} - int ACE::HTBP::Addr::set (u_short port, const char host[], diff --git a/ACE/protocols/ace/HTBP/HTBP_Addr.h b/ACE/protocols/ace/HTBP/HTBP_Addr.h index 21e6ec353033c..695f9ddcbc8c2 100644 --- a/ACE/protocols/ace/HTBP/HTBP_Addr.h +++ b/ACE/protocols/ace/HTBP/HTBP_Addr.h @@ -43,7 +43,10 @@ namespace ACE /// Constructor Addr () = default; - Addr (const Addr &other); + Addr (const Addr &) = default; + Addr (Addr&&) = default; + Addr& operator= (const Addr&) = default; + Addr& operator= (Addr&&) = default; /// Create an Addr suitable for use on the inside of a firewall this /// take a string used to populate the htid_ member. With this address, @@ -58,7 +61,7 @@ namespace ACE int address_family = AF_UNSPEC); /// Destructor - virtual ~Addr () = default; + ~Addr () override = default; int set (u_short port, const char host [], @@ -68,9 +71,9 @@ namespace ACE /// and vice versa int addr_to_string (ACE_TCHAR buffer[], size_t size, - int ipaddr_format = 1) const; + int ipaddr_format = 1) const override; int string_to_addr (const char address[], - int address_facmily = AF_UNSPEC); + int address_facmily = AF_UNSPEC) override; int set_htid(const char *htid); const char *get_htid () const; From ea53d39e0a8a9608988d2d4f09da2b68dbdc8133 Mon Sep 17 00:00:00 2001 From: Johnny Willemsen Date: Fri, 6 Jun 2025 11:54:12 +0200 Subject: [PATCH 2/2] Update ACE/protocols/ace/HTBP/HTBP_Addr.h Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- ACE/protocols/ace/HTBP/HTBP_Addr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ACE/protocols/ace/HTBP/HTBP_Addr.h b/ACE/protocols/ace/HTBP/HTBP_Addr.h index 695f9ddcbc8c2..764047b50f0ec 100644 --- a/ACE/protocols/ace/HTBP/HTBP_Addr.h +++ b/ACE/protocols/ace/HTBP/HTBP_Addr.h @@ -73,7 +73,7 @@ namespace ACE size_t size, int ipaddr_format = 1) const override; int string_to_addr (const char address[], - int address_facmily = AF_UNSPEC) override; + int address_family = AF_UNSPEC) override; int set_htid(const char *htid); const char *get_htid () const;