Skip to content

Fixed compiler warnings, use default/override #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwillemsen merged 3 commits into from
Jun 6, 2025
Merged

Fixed compiler warnings, use default/override #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19c4722
Fixed compiler warnings, use default/override
jwillemsen Jun 6, 2025
ea53d39
Update ACE/protocols/ace/HTBP/HTBP_Addr.h
jwillemsen Jun 6, 2025
8e326aa
Merge branch 'master' into jwi-htbpwarning
jwillemsen Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ACE/protocols/ace/HTBP/HTBP_Addr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ ACE::HTBP::Addr::Addr (const char *htid)
{
}

ACE::HTBP::Addr::Addr (const ACE::HTBP::Addr &other)
: ACE_INET_Addr (other),
htid_(other.htid_)
{
}

int
ACE::HTBP::Addr::set (u_short port,
const char host[],
Expand Down
11 changes: 7 additions & 4 deletions ACE/protocols/ace/HTBP/HTBP_Addr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ namespace ACE
/// Constructor
Addr () = default;

Addr (const Addr &other);
Addr (const Addr &) = default;
Addr (Addr&&) = default;
Addr& operator= (const Addr&) = default;
Addr& operator= (Addr&&) = default;

/// Create an Addr suitable for use on the inside of a firewall this
/// take a string used to populate the htid_ member. With this address,
Expand All @@ -58,7 +61,7 @@ namespace ACE
int address_family = AF_UNSPEC);

/// Destructor
virtual ~Addr () = default;
~Addr () override = default;

int set (u_short port,
const char host [],
Expand All @@ -68,9 +71,9 @@ namespace ACE
/// and vice versa
int addr_to_string (ACE_TCHAR buffer[],
size_t size,
int ipaddr_format = 1) const;
int ipaddr_format = 1) const override;
int string_to_addr (const char address[],
int address_facmily = AF_UNSPEC);
int address_family = AF_UNSPEC) override;

int set_htid(const char *htid);
const char *get_htid () const;
Expand Down