Only platforms with a 32bit time_t signed will have problems in 2038,…#2407
Merged
Conversation
… with 32bit time_t unsigned we have until 2106
* ACE/tests/Time_Value_Test.cpp:
Contributor
WalkthroughThe code in the time value test now differentiates between signed and unsigned 32-bit Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (19)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ACE/tests/Time_Value_Test.cpp(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (21)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: ubuntu-22.04 clang++-13
- GitHub Check: ubuntu-24.04 g++-10 ACE for TAO
- GitHub Check: ubuntu-24.04 g++-10 wchar
- GitHub Check: ubuntu-22.04 clang++-12
- GitHub Check: ubuntu-24.04 clang++-14
- GitHub Check: ubuntu-24.04 g++-10 CodeQL
- GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
- GitHub Check: ubuntu-24.04 clang++-16
- GitHub Check: ubuntu-24.04 g++-10 CORBA/e micro
- GitHub Check: macos-13-C++
- GitHub Check: macos-14-C++
- GitHub Check: ubuntu-24.04 clang++-15
- GitHub Check: ubuntu-24.04 g++-12
- GitHub Check: ubuntu-24.04 g++-11
- GitHub Check: ubuntu-24.04 g++-13
- GitHub Check: ubuntu-22.04 g++-10
- GitHub Check: ubuntu-22.04 g++-9
- GitHub Check: ubuntu-24.04 g++-14
- GitHub Check: alpine-3.18
- GitHub Check: ubuntu-24.04 g++
🔇 Additional comments (2)
ACE/tests/Time_Value_Test.cpp (2)
213-223: Well-implemented differentiation between signed and unsigned 32-bit time_t.The logic correctly distinguishes between the two scenarios:
- Signed 32-bit time_t: Will overflow to negative in 2038 (treated as error)
- Unsigned 32-bit time_t: Will overflow in 2106 without going negative (treated as debug info)
This differentiation makes technical sense as the severity and timeline differ significantly between these cases.
217-217: Verify the intentional test behavior change.This modification changes the test's behavior: platforms with unsigned 32-bit time_t will now pass the test (no error count increment) instead of failing. Please confirm this behavioral change aligns with the intended test semantics.
Also applies to: 223-223
* ACE/tests/Time_Value_Test.cpp:
Member
Author
|
@Mergifyio backport ace6tao2 |
✅ Backports have been createdDetails
|
jwillemsen
added a commit
that referenced
this pull request
Jun 24, 2025
[ace6tao2] Only platforms with a 32bit time_t signed will have problems in 2038,… (backport #2407)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… with 32bit time_t unsigned we have until 2106
Summary by CodeRabbit