Skip to content

[ace6tao2] Only platforms with a 32bit time_t signed will have problems in 2038,… (backport #2407)#2408

Merged
jwillemsen merged 3 commits into
ace6tao2from
mergify/bp/ace6tao2/pr-2407
Jun 24, 2025
Merged

[ace6tao2] Only platforms with a 32bit time_t signed will have problems in 2038,… (backport #2407)#2408
jwillemsen merged 3 commits into
ace6tao2from
mergify/bp/ace6tao2/pr-2407

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jun 24, 2025

… with 32bit time_t unsigned we have until 2106

* ACE/tests/Time_Value_Test.cpp:

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling and messaging for different 32-bit time types, providing clearer notifications about potential time-related issues after 2038 or 2106 depending on system configuration.

This is an automatic backport of pull request #2407 done by [Mergify](https://mergify.com).

… with 32bit time_t unsigned we have until 2106

    * ACE/tests/Time_Value_Test.cpp:

(cherry picked from commit 39162ba)
    * ACE/tests/Time_Value_Test.cpp:

(cherry picked from commit c0f0bb3)

# Conflicts:
#	ACE/tests/Time_Value_Test.cpp
@mergify mergify Bot added the conflicts label Jun 24, 2025
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Jun 24, 2025

Cherry-pick of c0f0bb3 has failed:

On branch mergify/bp/ace6tao2/pr-2407
Your branch is ahead of 'origin/ace6tao2' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit c0f0bb3c14.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ACE/tests/Time_Value_Test.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 24, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jwillemsen jwillemsen changed the title Only platforms with a 32bit time_t signed will have problems in 2038,… (backport #2407) [ace6tao2] Only platforms with a 32bit time_t signed will have problems in 2038,… (backport #2407) Jun 24, 2025
@jwillemsen jwillemsen merged commit ac45330 into ace6tao2 Jun 24, 2025
55 checks passed
@jwillemsen jwillemsen deleted the mergify/bp/ace6tao2/pr-2407 branch June 24, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant