Use constexpr for constant instead of enum

[jwillemsen]

* ACE/tests/Memcpy_Test.cpp:

Summary by CodeRabbit

• Refactor
  • Improved code clarity and const-correctness in internal test logic. No changes to user-facing functionality.

[coderabbitai]

Warning

Rate limit exceeded

@jwillemsen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 552fbb8 and 88cac2f.

📒 Files selected for processing (1)

• ACE/tests/Memcpy_Test.cpp (2 hunks)

Walkthrough

The changes update several constants from const or enum types to constexpr for compile-time evaluation and adjust loop counters from int to size_t for type consistency. Timing variables were changed from mutable double to const double to enforce immutability. No logic or control flow was altered.

Changes

File(s)	Change Summary
ACE/tests/Memcpy_Test.cpp	Changed size and ITERATIONS to constexpr size_t; updated loop counters to size_t; made timing variables fast and slow const double for improved type and const-correctness.

Poem

A constant’s form now sharp and clear,
constexpr whispers, compile-time near.
Loops count true with size_t stride,
Timers fixed, no change to hide.
A rabbit hops with code refined,
Const-correctness, sweetly aligned! 🐇💻✨

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

ACE/tests/Memcpy_Test.cpp (2)

75-75: Prefer std::size_t (or another unsigned type) for iteration constants
ITERATIONS is only ever used as an upper-bound/count in loops and is never expected to be negative. Declaring it as

constexpr std::size_t ITERATIONS = 100'000'000;

better conveys that intent, avoids any accidental sign conversions, and future-proofs the code should the literal be increased beyond INT_MAX.

---

94-106: Keep timing variables consistent & immutable
slow has been changed to const, but fast—computed just above—remains mutable. Making both const (and optionally applying a digit separator for readability) tightens correctness and surfaces intent:

-  double fast = 1000000  *(now.tv_sec - start.tv_sec) +
-    now.tv_usec - start.tv_usec;
+  const double fast = 1'000'000 * (now.tv_sec - start.tv_sec) +
+                      (now.tv_usec - start.tv_usec);

No functional change, just uniform const-correctness.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 552fbb8 and c16a3af.

📒 Files selected for processing (1)

• ACE/tests/Memcpy_Test.cpp (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)

• GitHub Check: macos-13-C++
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-24.04 clang++-15
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-24.04 clang++-16
• GitHub Check: ubuntu-24.04 g++-14
• GitHub Check: alpine-3.18
• GitHub Check: VS2022Debug64Cxx17
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Release64
• GitHub Check: VS2022Debug64Cxx20
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Release32
• GitHub Check: MINGW64-gcc
• GitHub Check: VS2022Debug32
• GitHub Check: windows-2022 vs2022
• GitHub Check: ubuntu-24.04 g++

[jwillemsen]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.