Fixed compile errors with C++23

[jwillemsen]

Summary by CodeRabbit

• Refactor
  • Improved class definitions and method declarations for better clarity and consistency.
  • Updated method signatures to clearly indicate overridden functions.

[coderabbitai]

Walkthrough

The changes update the ImR_Locator_Loader class by explicitly defaulting its constructor, adding a custom destructor, and marking several overridden methods with the override keyword instead of virtual. The implementation file is updated to define the destructor, replacing the previous constructor definition.

Changes

File(s)	Change Summary
TAO/orbsvcs/ImplRepo_Service/Locator_Loader.h	Defaulted the constructor, added a destructor, and replaced virtual with override for several method declarations.
TAO/orbsvcs/ImplRepo_Service/Locator_Loader.cpp	Replaced an empty constructor definition with an empty destructor definition.

Poem

A loader's life, now clear and neat,
With overrides and destructor's beat.
Constructors default, the code refined,
In header and source, changes aligned.
The bunny hops with coder's cheer—
Cleaner code is always dear!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2adb981 and ae228e4.

📒 Files selected for processing (2)

• TAO/orbsvcs/ImplRepo_Service/Locator_Loader.cpp (1 hunks)
• TAO/orbsvcs/ImplRepo_Service/Locator_Loader.h (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

TAO/orbsvcs/ImplRepo_Service/Locator_Loader.cpp (1)

TAO/orbsvcs/ImplRepo_Service/Locator_Loader.h (3)

• ImR_Locator_Loader (17-43)
• ImR_Locator_Loader (21-21)
• ImR_Locator_Loader (41-41)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: VS2022Debug64Cxx17
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Release32
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022Debug64Cxx20
• GitHub Check: VS2022Release64
• GitHub Check: MINGW64-gcc
• GitHub Check: VS2022Debug32
• GitHub Check: ubuntu-24.04 clang++-16
• GitHub Check: ubuntu-24.04 g++-10 CORBA/e compact
• GitHub Check: ubuntu-24.04 clang++-14
• GitHub Check: ubuntu-22.04 clang++-13
• GitHub Check: ubuntu-22.04 g++-9
• GitHub Check: ubuntu-24.04 g++-13
• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: ubuntu-24.04 g++-11
• GitHub Check: ubuntu-24.04 g++-12
• GitHub Check: ubuntu-22.04 clang++-12
• GitHub Check: ubuntu-24.04 g++

🔇 Additional comments (3)

TAO/orbsvcs/ImplRepo_Service/Locator_Loader.h (2)

20-20: Good modernization for C++23 compatibility.

Explicitly defaulting the constructor is a good practice and helps avoid potential issues with the rule of five/zero in modern C++.

---

21-21: Appropriate destructor declaration.

Adding a destructor declaration is consistent with modern C++ practices when you have custom resource management, even if the destructor implementation is empty.

TAO/orbsvcs/ImplRepo_Service/Locator_Loader.cpp (1)

23-25: Consistent with header changes.

The change from constructor implementation to destructor implementation is correct and consistent with the header file changes. The empty destructor body is appropriate since:

1. runner_ is a std::unique_ptr that handles its own cleanup
2. service_ and opts_ appear to be value types that handle their own destruction
3. The destructor serves as a placeholder for any future cleanup logic if needed

[mitza-oci]

What was the error?

[jwillemsen]

unique_ptr.h: invalid application of 'sizeof' to an incomplete type 'ImR_Locator_ORB_Runner

[mitza-oci]

unique_ptr.h: invalid application of 'sizeof' to an incomplete type 'ImR_Locator_ORB_Runner

I wonder why we didn't see it on either build on https://www.dre.vanderbilt.edu/scoreboard/tao.html (both -std=c++23)?

[jwillemsen]

This is with another compiler which uses C++23 as default, but can't share the logs and details publicly at this moment.