Use static constexpr instead of anonymous enums

[jwillemsen]

* ACE/apps/JAWS/server/HTTP_Server.cpp:

Summary by CodeRabbit

• Refactor
  • Updated internal handling of certain constants to improve maintainability. No changes to functionality or user experience.

[coderabbitai]

Walkthrough

The update modifies the JAWS class in the HTTP server by replacing two unnamed enum declarations with four static constexpr int constants. The integer values and their meanings remain unchanged, but the declaration style is updated to use constexpr variables instead of enum members.

Changes

File(s)	Change Summary
ACE/apps/JAWS/server/HTTP_Server.cpp	Replaced two unnamed enum declarations with four static constexpr int constants in JAWS class

Poem

In the server's code, enum days are gone,
Constexpr bunnies now hop along.
Four constants stand with type and might,
Still holding values, crisp and right.
A modern hop for code so neat—
This rabbit’s work is now complete! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d3875c and 160e132.

📒 Files selected for processing (1)

• ACE/apps/JAWS/server/HTTP_Server.cpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ACE/apps/JAWS/server/HTTP_Server.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: ubuntu-22.04 g++-10
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: macos-14-C++
• GitHub Check: macos-13-C++
• GitHub Check: ubuntu-22.04 g++-12
• GitHub Check: windows-2022 vs2022
• GitHub Check: ubuntu-24.04 g++

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

ACE/apps/JAWS/server/HTTP_Server.cpp (1)

20-24: static keyword is superfluous on in-class constexpr variables

Since C++17 an in-class constexpr variable is implicitly inline static, so the leading static adds no functionality and can be dropped for brevity.

-  static constexpr int JAWS_POOL = 0;
+  constexpr int JAWS_POOL = 0;

(Applies to the other three constants as well.)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c04ec6b and 3d3875c.

📒 Files selected for processing (1)

• ACE/apps/JAWS/server/HTTP_Server.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: ubuntu-24.04 g++-13
• GitHub Check: macos-14-C++
• GitHub Check: macos-13-C++
• GitHub Check: VS2022Debug64Cxx20
• GitHub Check: VS2022Release64
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Debug64Cxx17
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022WChar
• GitHub Check: VS2022Release32
• GitHub Check: VS2022Debug32
• GitHub Check: windows-2022 vs2022
• GitHub Check: ubuntu-24.04 g++
• GitHub Check: MINGW64-gcc
• GitHub Check: ubuntu-22.04 g++-12
• GitHub Check: alpine-3.18