Use namespace instead of class

[jwillemsen]

* ACE/apps/JAWS/server/HTTP_Server.cpp:

Summary by CodeRabbit

• Refactor
  • Updated the structure for defining certain constants, with no impact on application behavior or visible features.

[coderabbitai]

Walkthrough

The change refactors the definition of several constants in HTTP_Server.cpp by moving them from a static constexpr class to a namespace. The constants themselves and their values remain unchanged, but their enclosing structure is now a namespace instead of a class.

Changes

File(s)	Change Summary
ACE/apps/JAWS/server/HTTP_Server.cpp	Replaced JAWS class containing static constexpr constants with a JAWS namespace containing the same constants. Removed class declaration and access specifier.

Sequence Diagram(s)

sequenceDiagram
    participant Code
    participant JAWS Namespace

    Code->>JAWS Namespace: Access JAWS_POOL, JAWS_PER_REQUEST, JAWS_SYNCH, JAWS_ASYNCH

Loading

Possibly related PRs

• Use static constexpr instead of anonymous enums #2427: Also modifies the declarations of the same constants in HTTP_Server.cpp, transitioning from enums to static constexpr members within a class, which is further refactored in this PR.

Poem

In the code where constants dwell,
A namespace now rings the bell.
No more class with static pride,
The values stay, but scope’s now wide.
JAWS swims on, just as before,
In clearer waters, constants soar!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 372e143 and aa04330.

📒 Files selected for processing (1)

• ACE/apps/JAWS/server/HTTP_Server.cpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ACE/apps/JAWS/server/HTTP_Server.cpp

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

ACE/apps/JAWS/server/HTTP_Server.cpp (1)

16-23: Prefer inline constexpr (or plain constexpr) over static constexpr at namespace scope

At namespace scope static gives each translation unit its own copy of the variable (internal linkage).
The previous class-static constants had external linkage, so any other translation unit could reference a single definition.
If these constants are (or will be) accessed outside this .cpp, the current change silently alters the linkage and can lead to ODR bloat or link errors.

A minimal, C++17-friendly tweak:

-namespace JAWS
-{
-  static constexpr size_t JAWS_POOL = 0;
-  static constexpr size_t JAWS_PER_REQUEST = 1;
-
-  static constexpr size_t JAWS_SYNCH = 0;
-  static constexpr size_t JAWS_ASYNCH = 2;
-}
+namespace JAWS
+{
+  inline constexpr std::size_t JAWS_POOL        = 0;
+  inline constexpr std::size_t JAWS_PER_REQUEST = 1;
+
+  inline constexpr std::size_t JAWS_SYNCH  = 0;
+  inline constexpr std::size_t JAWS_ASYNCH = 2;
+}

• inline preserves the single-definition semantics across TUs
• std::size_t comes from <cstddef> and is the canonical type

If the constants are truly implementation-only for this file, dropping static entirely (constexpr std::size_t …) keeps the linkage internal while avoiding the dated specifier.

Please double-check that no header or other .cpp relies on these symbols; if they do, switching to inline (or moving the block to a header) is required.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ffa2efd and 372e143.

📒 Files selected for processing (1)

• ACE/apps/JAWS/server/HTTP_Server.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Codacy Static Code Analysis