Don't set ACE_HAS_TIME_T_LONG_MISMATCH when we have a 64bit build with Visual Studio

[jwillemsen]

…SE_32BIT_TIME_T can only be used when building 32bit

* ACE/ace/config-win32-msvc-141.h:

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where time type mismatch handling was incorrectly applied to 64-bit Windows builds. This adjustment ensures proper compatibility for 64-bit Windows environments.

[coderabbitai]

Walkthrough

The conditional compilation logic for defining the ACE_HAS_TIME_T_LONG_MISMATCH macro in the Windows MSVC 141 configuration header was updated. The macro is now excluded from 64-bit Windows builds by adding a check for ACE_WIN64 not being defined, narrowing its applicability.

Changes

File(s)	Change Summary
ACE/ace/config-win32-msvc-141.h	Updated preprocessor condition for ACE_HAS_TIME_T_LONG_MISMATCH to exclude 64-bit Windows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip through headers so neat,
The rabbit refines where macros compete.
No mismatch for time on Win64’s land,
Just a tweak of a check, by a careful hand.
With whiskers a-twitch, the code is now right—
Hopping along, everything’s light!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

ACE/ace/config-win32-msvc-141.h (1)

33-35: Condition refined correctly; please align comment and consider _WIN64

The added && !defined(ACE_WIN64) correctly prevents ACE_HAS_TIME_T_LONG_MISMATCH from being set on 64-bit builds. 👍
Two minor follow-ups:

1. Lines 29-32 still describe the issue as 32-bit–specific; updating that comment will avoid confusion.
2. Relying on the compiler macro _WIN64 (or guarding with both) is slightly safer in case ACE_WIN64 is not yet defined when this header is parsed.

Example tweak:

-#if !defined (_USE_32BIT_TIME_T) && !defined (ACE_WIN64)
+#if !defined (_USE_32BIT_TIME_T) && !defined (ACE_WIN64) && !defined (_WIN64)

Not blocking, just polish.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 780c0e9 and 090bf1c.

📒 Files selected for processing (1)

• ACE/ace/config-win32-msvc-141.h (1 hunks)

[jwillemsen]

Existing code is correct for msvc, timeval is a long which is 32bit, time_t is 64bit when _USE_32BIT_TIME_T is not defined. With msvc the casts are necessary to hide a conversion warning. On windows timeval is only used for intervals, so 32bit there is not a problem.