Skip to content

Test whether time_t is correctly converted to year/month, also with d… #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwillemsen merged 2 commits into from
Jul 26, 2025
Merged

Test whether time_t is correctly converted to year/month, also with d… #2435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a6babf
Test whether time_t is correctly converted to year/month, also with d…
jwillemsen Jul 26, 2025
ed90304
Correct test
jwillemsen Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions ACE/tests/Time_Value_Test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "test_config.h"
#include "ace/ACE.h"
#include "ace/Time_Value.h"
#include "ace/Date_Time.h"
#include "ace/Numeric_Limits.h"
#include <sstream>
#include <type_traits>
Expand Down Expand Up @@ -52,6 +53,38 @@ int timeval_test_func (const ACE_Time_Value* timeout)
return ret;
}

// Test whether ACE_Time_Value is stored correctly for the specified year month
int test_year_month (const ACE_Time_Value& time, long year, long month)
{
int ret = 0;

ACE_Date_Time dt (time);
if (dt.year () != year)
{
ACE_ERROR ((LM_ERROR,
ACE_TEXT ("time year should be %d not %d\n"), dt.year (), year));
++ret;
}
else
{
ACE_DEBUG ((LM_DEBUG,
ACE_TEXT ("time year is correct, it is %d\n"), dt.year ()));
}
if (dt.month () != month)
{
ACE_ERROR ((LM_ERROR,
ACE_TEXT ("time month should be %d not %d\n"), dt.month (), month));
++ret;
}
else
{
ACE_DEBUG ((LM_DEBUG,
ACE_TEXT ("time month is correct, it is %d\n"), dt.month ()));
}

return ret;
}

int
run_main (int, ACE_TCHAR *[])
{
Expand Down Expand Up @@ -261,6 +294,14 @@ run_main (int, ACE_TCHAR *[])

ret += timeval_test_func ((ACE_Time_Value *) &ACE_Time_Value::zero);

// Test whether some times in the past and the future are correctly converted to year/month, no need to check
// day/time as that could be challenging due to timezones.
ACE_Time_Value dt20250726 ((time_t)1753519444);
ret += test_year_month (dt20250726, 2025, 7);
ACE_Time_Value dt20370726 ((time_t)2132203444);
ret += test_year_month (dt20370726, 2037, 7);
ACE_Time_Value dt20570726 ((time_t)2763355444);
ret += test_year_month (dt20570726, 2057, 7);
ACE_END_TEST;

return ret;
Expand Down
Loading