Skip to content

Remove NSK from list test lst files#2529

Merged
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-cleanupnsk
Apr 10, 2026
Merged

Remove NSK from list test lst files#2529
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-cleanupnsk

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented Apr 10, 2026

* ACE/bin/ace_tests.lst:
* ACE/tests/run_test.lst:

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated test platform configurations to enable tests on an additional platform by removing specific platform exclusions from multiple test entries.

    * ACE/bin/ace_tests.lst:
    * ACE/tests/run_test.lst:
@jwillemsen jwillemsen linked an issue Apr 10, 2026 that may be closed by this pull request
@jwillemsen jwillemsen merged commit f8c5e56 into DOCGroup:master Apr 10, 2026
34 of 36 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 10, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b733ad7d-5acb-45f1-953b-09f97e434a1e

📥 Commits

Reviewing files that changed from the base of the PR and between f9c693d and 0649a9d.

📒 Files selected for processing (2)
  • ACE/bin/ace_tests.lst
  • ACE/tests/run_test.lst

Walkthrough

The PR removes !nsk platform exclusion qualifiers from multiple test entries across two ACE test configuration files, expanding test coverage to NSK platforms. Changes affect tests in both ACE/bin/ace_tests.lst and ACE/tests/run_test.lst.

Changes

Cohort / File(s) Summary
Test Configuration Updates
ACE/bin/ace_tests.lst, ACE/tests/run_test.lst
Removed !nsk platform exclusion qualifier from test configuration entries, allowing previously NSK-excluded tests (e.g., HTBP, RMCast, Dev_Poll_Reactor_Test, Proactor_* variants, and 20+ others) to run on NSK platforms.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Hop skip and bound through tests so grand,
NSK platforms now understand,
We removed those !nsk little blockers,
Now every reactor can wear its socks-ers! 🧦

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen jwillemsen deleted the jwi-cleanupnsk branch April 10, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remove NSK from lst files

1 participant