Skip to content

Fix error#2536

Merged
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-usingfix
May 6, 2026
Merged

Fix error#2536
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-usingfix

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented May 6, 2026

* ACE/ace/Event_Handler_T.h:

Summary by CodeRabbit

  • Bug Fixes

    • Corrected corrupted template typedef declarations in event handler template class.
  • New Features

    • Added SET_HANDLE typedef alias for enhanced API consistency.

    * ACE/ace/Event_Handler_T.h:
@jwillemsen jwillemsen merged commit f053712 into DOCGroup:master May 6, 2026
33 of 35 checks passed
@jwillemsen jwillemsen deleted the jwi-usingfix branch May 6, 2026 09:49
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 88855a2c-b488-4ae6-acd4-5c4b077ee95e

📥 Commits

Reviewing files that changed from the base of the PR and between b86aaf6 and 598a2f7.

📒 Files selected for processing (1)
  • ACE/ace/Event_Handler_T.h

Walkthrough

Template typedefs in ACE_Event_Handler_T are corrected by removing stray tokens and introducing a proper SET_HANDLE member function pointer typedef alongside the clarified SIG_HANDLER declaration.

Changes

Template Typedef Cleanup

Layer / File(s) Summary
Typedef Declarations
ACE/ace/Event_Handler_T.h
Removed stray tokens corrupting the typedef region. Added SET_HANDLE typedef for void (T::*)(ACE_HANDLE) and replaced malformed token before SIG_HANDLER with proper using declaration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A stray token fled the template's care,
Now typedefs sit in order fair,
SET_HANDLE placed with gentle grace,
SIG_HANDLER claims its rightful place!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant