Fix missing override warnings

[jwillemsen]

* ACE/ace/Asynch_IO_Impl.h:
* ACE/ace/Connector.h:
* ACE/ace/Select_Reactor_T.h:

Summary by CodeRabbit

• Refactor
  • Simplified asynchronous file read operations by removing offset parameters from method signatures, making the API more streamlined.
  • Updated virtual method declarations to use modern C++ override semantics for improved code clarity and maintainability.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e53e129a-7aaa-4d03-b15c-c5b5d044b2e9

📥 Commits

Reviewing files that changed from the base of the PR and between f053712 and 7055722.

📒 Files selected for processing (3)

• ACE/ace/Asynch_IO_Impl.h
• ACE/ace/Connector.h
• ACE/ace/Select_Reactor_T.h

---

Walkthrough

This PR modernizes the ACE library headers by adopting C++11's override specifier across virtual method declarations and simplifying the async file read interface by removing offset parameters from read and readv methods.

Changes

Async File Read API and Virtual Method Modernization

Layer / File(s)	Summary
Async File Read Signature Simplification ACE/ace/Asynch_IO_Impl.h	ACE_Asynch_Read_File_Impl::read() and readv() remove offset and offset_high parameters, reducing arity from 7 to 5 parameters.
Override Specifier Adoption ACE/ace/Asynch_IO_Impl.h, ACE/ace/Connector.h, ACE/ace/Select_Reactor_T.h	Virtual methods across three classes gain override keyword: read/readv in Asynch_Read_File_Impl, initialize_svc_handler and non_blocking_handles in Connector, and Win32 register_handler in Select_Reactor_T. Connector::initialize_svc_handler explicitly removes virtual keyword in favor of override.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Whiskers twitch with glee,
Hopping through virtual trees,
Override, offset—freed!
Modern C++ for all to see, 🐰✨
Cleaner code, happy we!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix missing override warnings' directly and clearly summarizes the main objective of the pull request, which is to add override specifiers to method declarations across three files to address compiler warnings.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}