added parquet support for control networks by Kelvinrr · Pull Request #5905 · DOI-USGS/ISIS3

Kelvinrr · 2025-11-25T19:29:08Z

Description

Adds parquet reading, getting weird SPICE errors that may or may not be related to these changes, some things are me messing with random errors on camera creation.

Related Issue

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2025-11-25T19:29:49Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-06-30T16:19:07Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-06-30T20:00:28Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-06-30T20:03:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

chkim-usgs · 2026-07-01T14:51:15Z

@@ -0,0 +1 @@
+Added Parquet support for control netowrks


typo: netowrks -> networks

Also since this is a new feature, fragment should probably be +20260630130235.add.md instead of fix.

chkim-usgs · 2026-07-01T14:52:14Z

   */
  Spice::~Spice() {
-    NaifStatus::CheckErrors();
+    // NaifStatus::CheckErrors();


I'm guessing this is due to the weird SPICE errors that are occasionally occurring which you mentioned in the PR body.

yeah, I fixed it though so I should uncomment.

chkim-usgs · 2026-07-01T14:53:32Z

 }

+// Reading a nonexistent VSI path throws an IException rather than crashing.
+TEST(FileList, VsiMissingFileThrows)


Are we able to add more validation tests for the write/read/verify Parquet process?

chkim-usgs · 2026-07-01T14:55:30Z

  - jama
  - kalasiris
  - krb5
-  - libboost >=1.88.0,<1.89


Just checking that libboost was removed as a dependency here compared to it being necessary for ARM builds.

github-actions · 2026-07-01T17:18:16Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-07-01T17:25:00Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

chkim-usgs · 2026-07-01T17:47:18Z

Will need to remove this fragment since we have the one with *.add.md

github-actions · 2026-07-01T19:22:15Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5905".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

added parquet support

f1cf78e

Kelvinrr changed the title ~~added parquet support~~ added parquet support or control networks Nov 25, 2025

Kelvinrr changed the title ~~added parquet support or control networks~~ added parquet support for control networks Jan 9, 2026

Kelvinrr added 6 commits June 27, 2026 19:45

checkpoint, more additions

11182b0

checkpoint

641d339

merge conflicts

4e8fd92

Merge branch 'dev' of github.com:DOI-USGS/ISIS3 into gdalnet

5940cdb

adding deps to meta.yml

976c105

added VSI support for image lists

4ad93fa

Kelvinrr marked this pull request as ready for review June 30, 2026 16:18

Kelvinrr added 2 commits June 30, 2026 09:19

Merge branch 'dev' of github.com:DOI-USGS/ISIS3 into gdalnet

49e550b

minor changes

db51a31

added changelog

e38dfbe

Kelvinrr requested a review from chkim-usgs June 30, 2026 22:52

chkim-usgs reviewed Jul 1, 2026

View reviewed changes

comments

9dd44a0

fixed log

a6a72e5

chkim-usgs reviewed Jul 1, 2026

View reviewed changes

rm frag

47b4e05

chkim-usgs approved these changes Jul 1, 2026

View reviewed changes

chkim-usgs merged commit ca37f98 into DOI-USGS:dev Jul 1, 2026
3 checks passed

Uh oh!

Conversation

Kelvinrr commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

chkim-usgs Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

chkim-usgs Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

chkim-usgs Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Kelvinrr Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

chkim-usgs Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

chkim-usgs Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

chkim-usgs Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kelvinrr commented Nov 25, 2025 •

edited

Loading