Skip to content

Commit 07ed123

Browse files
committed
Revert StringFilter/StringList aliases; use inline PEP 604 unions
Per code-review feedback: domain-specific type aliases hide what the annotations actually mean. PEP 604 unions are the pythonic idiom and show the caller exactly what's accepted at the call site. - `StringFilter` (172 sites) -> `str | Iterable[str] | None` - `StringList` (8 sites) -> `list[str] | None` Runtime behavior is unchanged: `_get_args` still routes filter params through `_normalize_str_iterable` (accepts str, list, tuple, Series, ndarray, generator) and `properties` through `_LIST_ONLY_STR_PARAMS` (wraps stray single-string input into a one-element list).
1 parent 749f72e commit 07ed123

2 files changed

Lines changed: 182 additions & 200 deletions

File tree

0 commit comments

Comments
 (0)