fix(waterdata): materialize numpy/Series numeric params instead of str()-ing them

A numeric (_NO_NORMALIZE_PARAMS) param — water_year, year, month, day,
thresholds, … — passed as a numpy array or pandas Series fell into the
`args[k] = v` passthrough in _get_args without being materialized to a list.
Downstream, the GET comma-join and the chunker both test `list`/`tuple`, so an
ndarray/Series was neither comma-joined nor chunked: e.g.
get_peaks(water_year=np.array([2020, 2021])) produced
`water_year=%5B2020+2021%5D` (the array's repr) instead of
`water_year=2020,2021`. Plain lists already worked.

Split the branch so _NO_NORMALIZE_PARAMS values keep their element types (no
string-normalization) but a non-string iterable is still listified.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: thodson-usgs

dataretrieval/waterdata/utils.py

@@ -2015,11 +2015,17 @@ def _get_args(
             args[k] = _check_monitoring_location_id(v)
         elif k == "properties":
             args[k] = _as_str_list(v, k)
-        elif (
-            k in _NO_NORMALIZE_PARAMS
-            or isinstance(v, str)
-            or not isinstance(v, Iterable)
-        ):
+        elif k in _NO_NORMALIZE_PARAMS:
+            # Numeric params (water_year, thresholds, …) keep their element
+            # types — don't string-normalize — but still materialize a
+            # non-string iterable (numpy array, pandas Series, generator) to a
+            # list so the GET comma-join and the chunker, which test
+            # ``list``/``tuple``, handle it instead of str()-ing the whole array
+            # into the URL.
+            args[k] = (
+                list(v) if isinstance(v, Iterable) and not isinstance(v, str) else v
+            )
+        elif isinstance(v, str) or not isinstance(v, Iterable):
             args[k] = v
         else:
             args[k] = _normalize_str_iterable(v, k)

tests/waterdata_test.py

@@ -35,6 +35,7 @@
     _check_profiles,
     _construct_api_requests,
     _construct_cql_request,
+    _get_args,
     _normalize_str_iterable,
 )
 
@@ -284,6 +285,17 @@ def test_construct_api_requests_numeric_list_joins_with_str():
     assert "water_year=2020%2C2021" in str(req.url)
 
 
+def test_get_args_materializes_numpy_and_series_numeric_params():
+    """Regression: numeric (_NO_NORMALIZE_PARAMS) params given as a numpy array
+    or pandas Series must be materialized to a list so they comma-join in the
+    URL — previously the array/Series repr leaked into the query string."""
+    for value in (np.array([2020, 2021]), pd.Series([2020, 2021])):
+        args = _get_args({"water_year": value})
+        assert args["water_year"] == [2020, 2021]
+        req = _construct_api_requests("peaks", **args)
+        assert "water_year=2020%2C2021" in str(req.url)
+
+
 def test_construct_api_requests_two_element_date_list_becomes_interval():
     """A two-element date list is interpreted as start/end of an OGC datetime
     interval (joined with '/'), NOT as two discrete dates. The OGC `datetime`