Commit 9c33c83
docs(ogc): apply /simplify quality-review nits (comments only)
Two documentation/comment fixes from the 4-angle cleanup review; no logic
change:
- utils._require_positive_int: soften the "count-like knobs ... can't drift"
claim. ChunkPlan.max_chunks deliberately bypasses the helper (internal,
already-int, keeps its own "1 disables fan-out" message), so scope the
claim to the two user-facing boundary knobs (max_rows, parallel_chunks).
- ChunkPlan._refine: note that its ranking key is atom count (len), not URL
bytes like _plan, because the fan-out pass balances work rather than
fitting a byte budget.
Considered-but-skipped from the review: extracting a shared
_largest_splittable helper for the _plan/_refine scans (line-neutral, adds
callable indirection — the depth review judged it more indirection than it
removes); removing _refine's max_chunks<=1 early-return (redundant with the
while-guard but a clearer explicit "off" marker); routing ChunkPlan's <1
guard through _require_positive_int (different contract, better bespoke
message); two _refine micro-optimizations (not worth it at max_chunks<=32).
Signed-off-by: thodson-usgs <thodson@usgs.gov>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 0cb5bfa commit 9c33c83
2 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
548 | 548 | | |
549 | 549 | | |
550 | 550 | | |
551 | | - | |
552 | | - | |
553 | | - | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
554 | 556 | | |
555 | 557 | | |
556 | 558 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
81 | 84 | | |
82 | 85 | | |
83 | 86 | | |
| |||
0 commit comments