Commit b09fbd2
Add tripwire: every named waterdata replacement must exist
Addresses Copilot review on #271: `_REPLACEMENTS` points
`get_discharge_peaks` -> `waterdata.get_peaks()` and `get_ratings` ->
`waterdata.get_ratings()`. If this PR merged before its dependencies
landed, users following the migration guidance would hit AttributeError.
Adds a parametrized test that imports `dataretrieval.waterdata` and
asserts every concrete callable named in the deprecation messages exists.
The test currently fails on `get_peaks` (still on PR #267, not yet on
main) — exactly the desired behavior: this PR cannot merge before #267.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent f9f0e4f commit b09fbd2
1 file changed
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
181 | 208 | | |
182 | 209 | | |
183 | 210 | | |
| |||
0 commit comments