Commit d3779de
fix(waterdata)!: return (df, BaseMetadata) from get_codes (#301)
Every other public waterdata getter returns a (DataFrame, BaseMetadata)
tuple, but get_codes returned a bare DataFrame, so the module's universal
idiom `df, md = waterdata.get_codes(...)` raised an unpack error. It already
builds `response` (and calls _raise_for_non_200), so the metadata was in hand
and discarded.
BREAKING: callers doing `df = get_codes(...)` must switch to
`df, _ = get_codes(...)`.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent b375f19 commit d3779de
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2101 | 2101 | | |
2102 | 2102 | | |
2103 | 2103 | | |
2104 | | - | |
| 2104 | + | |
2105 | 2105 | | |
2106 | 2106 | | |
2107 | 2107 | | |
| |||
2110 | 2110 | | |
2111 | 2111 | | |
2112 | 2112 | | |
| 2113 | + | |
| 2114 | + | |
| 2115 | + | |
| 2116 | + | |
| 2117 | + | |
| 2118 | + | |
| 2119 | + | |
2113 | 2120 | | |
2114 | 2121 | | |
2115 | 2122 | | |
| |||
2129 | 2136 | | |
2130 | 2137 | | |
2131 | 2138 | | |
2132 | | - | |
| 2139 | + | |
2133 | 2140 | | |
2134 | 2141 | | |
2135 | 2142 | | |
| |||
0 commit comments