Apply /simplify pass on duckdb connectors

* Narrow `_flatten_geometry` exception from `Exception` to `ValueError`
  (the actual error geopandas raises on `.x`/`.y` for non-Point
  geometries) so genuine bugs aren't swallowed.
* Drop the `if TYPE_CHECKING: import duckdb as _duckdb` block in
  `_base.py`. The runtime `try: import duckdb` is enough for type
  checkers; the alias was dead code.
* Parametrize `test_what_endpoint_invokes_correct_underlying` so each
  WQP helper gets its own test case (matches the parametrize pattern
  already used in `tests/waterdata_utils_test.py`).

20 tests pass; ruff clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: thodson-usgs

dataretrieval/duckdb_connectors/_base.py

@@ -17,7 +17,7 @@
 
 import logging
 from collections.abc import Callable
-from typing import TYPE_CHECKING, Any
+from typing import Any
 
 import pandas as pd
 
@@ -35,9 +35,6 @@
 except ImportError:
     GEOPANDAS = False
 
-if TYPE_CHECKING:
-    import duckdb as _duckdb  # noqa: F401  (resolved by type-checker only)
-
 logger = logging.getLogger(__name__)
 
 _INSTALL_HINT = (
@@ -96,8 +93,8 @@ def _flatten_geometry(df: pd.DataFrame) -> pd.DataFrame:
     try:
         out["longitude"] = geom.x
         out["latitude"] = geom.y
-    except Exception:
-        # Non-point geometries (lines, polygons): skip lon/lat shortcut.
+    except ValueError:
+        # geopandas raises ValueError on .x/.y for non-Point geometries.
         pass
 
     out[geom_name] = geom.to_wkt()

tests/duckdb_connectors_wqp_test.py

@@ -123,19 +123,21 @@ def test_join_results_to_sites(results_df, sites_df):
     ]
 
 
-def test_what_endpoints_invoke_correct_underlying(results_df):
+@pytest.mark.parametrize(
+    "helper",
+    [
+        "what_organizations",
+        "what_projects",
+        "what_activities",
+        "what_detection_limits",
+        "what_habitat_metrics",
+        "what_activity_metrics",
+    ],
+)
+def test_what_endpoint_invokes_correct_underlying(results_df, helper):
     """Each helper should invoke its corresponding wqp function."""
-    helper_to_target = {
-        "what_organizations": "what_organizations",
-        "what_projects": "what_projects",
-        "what_activities": "what_activities",
-        "what_detection_limits": "what_detection_limits",
-        "what_habitat_metrics": "what_habitat_metrics",
-        "what_activity_metrics": "what_activity_metrics",
-    }
-    for helper_name, target in helper_to_target.items():
-        with mock.patch(f"dataretrieval.wqp.{target}") as m:
-            m.return_value = (results_df, mock.Mock())
-            with wqp_connector.connect() as con:
-                getattr(con, helper_name)(statecode="US:17")
-            assert m.call_count == 1, helper_name
+    with mock.patch(f"dataretrieval.wqp.{helper}") as m:
+        m.return_value = (results_df, mock.Mock())
+        with wqp_connector.connect() as con:
+            getattr(con, helper)(statecode="US:17")
+        assert m.call_count == 1