Commit e4e4281
Apply Copilot PR #273 review: logger.error + future-proof helper docstring
Two small follow-ups from Copilot's review of 9c6481f:
- Revert `logger.exception` -> `logger.error` in both `_walk_pages` and
`get_stats_data` except blocks. The PR description always advertised
`logger.error("Request incomplete: %s", e)`; the simplify pass had
switched to `logger.exception(...)` (which auto-attaches a traceback)
but mid-pagination failures are expected, best-effort cases — the
exception text is already in the message via `%s`, and a per-page
traceback would be noisy. Reverting matches the PR description and
the original intent.
- Drop the literal count from `_error_log_messages`'s docstring. The
prior wording ("the four pagination-failure tests below") was already
stale-prone, and Copilot flagged it. Replaced with a count-free
phrasing so future test additions don't render it misleading.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 9c6481f commit e4e4281
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
683 | 683 | | |
684 | 684 | | |
685 | 685 | | |
686 | | - | |
| 686 | + | |
687 | 687 | | |
688 | 688 | | |
689 | 689 | | |
| |||
1147 | 1147 | | |
1148 | 1148 | | |
1149 | 1149 | | |
1150 | | - | |
| 1150 | + | |
1151 | 1151 | | |
1152 | 1152 | | |
1153 | 1153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | | - | |
| 110 | + | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
0 commit comments