This issue is to track feedback for an updated official software review.
The major changes from v1.0.0 to v1.1.4 center on comprehensive non-dendritic (divergence) network support.
accumulate_downstream() was expanded with three routing modes — dendritic, divergence-apportioned, and total upstream — the last using a new Tarjan-based bridge detection algorithm to prevent double-counting at rejoining diversions.- New functions
subset_network(), to_flownetwork(), and add_measures() were added and
make_index_ids() was unified to subsume the deprecated make_fromids() and format_index_ids() with a new mode parameter.- Navigation functions gained upmain/downmain modes, and
add_levelpaths() was rewritten with data.table for performance.
- Several bug fixes were applied to
add_toids(), sort_network(), and index_points_to_lines() (which also gained an ids parameter for constrained matching).
A thorough summary of changes can be seen here: #71
Code coverage was sustained over 95% and all package checks have been maintained for CRAN availability. This issue will be used to track colleague review.
This issue is to track feedback for an updated official software review.
The major changes from v1.0.0 to v1.1.4 center on comprehensive non-dendritic (divergence) network support.
accumulate_downstream()was expanded with three routing modes — dendritic, divergence-apportioned, and total upstream — the last using a new Tarjan-based bridge detection algorithm to prevent double-counting at rejoining diversions.subset_network(),to_flownetwork(), andadd_measures()were added andmake_index_ids()was unified to subsume the deprecatedmake_fromids()andformat_index_ids()with a new mode parameter.add_levelpaths()was rewritten with data.table for performance.add_toids(),sort_network(), andindex_points_to_lines()(which also gained an ids parameter for constrained matching).A thorough summary of changes can be seen here: #71
Code coverage was sustained over 95% and all package checks have been maintained for CRAN availability. This issue will be used to track colleague review.