Skip to content

update(modpath example): update and remove deprecated code from pyvista VTK example#153

Merged
mnfienen merged 6 commits into
DOI-USGS:mainfrom
jlarsen-usgs:main
Aug 8, 2025
Merged

update(modpath example): update and remove deprecated code from pyvista VTK example#153
mnfienen merged 6 commits into
DOI-USGS:mainfrom
jlarsen-usgs:main

Conversation

@jlarsen-usgs

Copy link
Copy Markdown
Contributor

No description provided.

@jlarsen-usgs

Copy link
Copy Markdown
Contributor Author

Hoping that these changes take care of the VTK failure issue on windows. If it doesn't, I'll try to investigate further into what might be causing the failure.

@mnfienen

Copy link
Copy Markdown
Collaborator

@jlarsen-usgs - looks like specifying OpenGL at 1.30 is causing issues on Windows. https://github.com/DOI-USGS/python-for-hydrology/actions/runs/15142496327/job/42571099793?pr=153

@jlarsen-usgs

Copy link
Copy Markdown
Contributor Author

@mnfienen -- Still trying to figure out how to fix this. There's not a lot of information about patching this error that I can find

@mnfienen

Copy link
Copy Markdown
Collaborator

right on - maybe we just exclude this nb from testing? It's the one that often has dependency issues....

@jlarsen-usgs

jlarsen-usgs commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

Excluding the test from windows might be the easiest course of action. I sent @wpbonelli a message to see if he's seen this error in the flopy testing before, because it runs the same example with pyvista

@mnfienen

Copy link
Copy Markdown
Collaborator

right on - let's see if @wpbonelli has a fix and if not, I guess we can exclude. Thanks for looking into this!

@mnfienen

mnfienen commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

hey @jlarsen-usgs - I was waiting to see if you got any clarity from Wes. If not, I guess we can exclude the test for now as you suggest.

@wpbonelli

Copy link
Copy Markdown
Contributor

Sorry guys I lost track of this. I don't know how to fix this yet. We are seeing it on flopy ci too.

@mnfienen

Copy link
Copy Markdown
Collaborator

@jlarsen-usgs and @wpbonelli - any chance we can revisit this again? Maybe just remove Windows for now?

@wpbonelli

Copy link
Copy Markdown
Contributor

@mnfienen @jlarsen-usgs I found pyvista/pyvista#4104 and beat my head on this on the flopy side for some time (environment variable magic, trying to get mesa3d instead, etc) and did not prevail so my rec would be to skip this one on windows for now

@jlarsen-usgs

Copy link
Copy Markdown
Contributor Author

@mnfienen updated testing to skip the modpath notebook on windows

@wpbonelli

Copy link
Copy Markdown
Contributor

I just realized we do this in the mf6 examples ci with https://github.com/pyvista/setup-headless-display-action

  - name: Set up headless display
    uses: pyvista/setup-headless-display-action@v4

maybe worth a shot. I can try it out on flopy and report back.

@wpbonelli

Copy link
Copy Markdown
Contributor

@mnfienen
mnfienen merged commit 290871e into DOI-USGS:main Aug 8, 2025
5 checks passed
@mnfienen

mnfienen commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

thanks @jlarsen-usgs and @wpbonelli for sorting this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants