Infrastructure: sealed-secrets resource requests (ionos_common — all envs)#2682
Merged
Merged
Conversation
Contributor
Author
|
PolitiRoberto
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2678
Summary
Adds CPU/memory resource requests and limits to the sealed-secrets controller, which currently runs with no resource requests at all. Defining requests/limits makes the pod schedulable predictably and protects the node from a runaway controller.
Change
Single file:
ionos_common/sealed-secrets/values.yaml— added aresources:block under the existing top-levelsealed-secrets:(subchart) key:This file lives in
ionos_common/, which is shared across every environment (dev, dev2, sbx, prd) — it is not PRD-only. This change applies the controller resources everywhere. That is intended and desirable: the sealed-secrets controller is identical and tiny in every environment.Sizing rationale
The controller's observed peak usage is ~23Mi memory / ~1m CPU. Requests (10m / 32Mi) sit comfortably above idle with headroom; limits (100m / 64Mi) leave ample burst room while staying small.
Verification (helm template)
Rendered the wrapper chart locally with
helm template(subchartsealed-secrets2.12.0 from the bitnami-labs chart). The bitnami-labs GitHub Pages helm repo index now returns 404, so the chart.tgzwas pulled from the GitHub release asset and vendored intocharts/for the render only (not committed).The resources block renders into the controller Deployment container spec:
The subchart template gates on
{{- if .Values.resources }}and emitsresources: {{- toYaml .Values.resources | nindent 12 }}, so the value atsealed-secrets: → resources:reaches the rendered manifest. This addresses the failure mode of PR #2492 (values placed at a path the chart never read).