Skip to content

Commit 4d33206

Browse files
committed
ignore
1 parent 1e80f61 commit 4d33206

2 files changed

Lines changed: 6 additions & 30 deletions

File tree

app/lint-baseline.xml

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,6 @@
1212
column="9"/>
1313
</issue>
1414

15-
<issue
16-
id="CredentialManagerMisuse"
17-
message="Call to `CredentialManager.getCredential` without use of `NoCredentialException`"
18-
errorLine1=" credentialManager.getCredential(context, request)"
19-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
20-
<location
21-
file="src/github/java/in/hridayan/ashell/settings/data/repository/GoogleAuthRepositoryImpl.kt"
22-
line="95"
23-
column="17"/>
24-
</issue>
25-
2615
<issue
2716
id="DefaultUncaughtExceptionDelegation"
2817
message="Must call `getDefaultUncaughtExceptionHandler()` to get the existing handler, and call `existingHandler.uncaughtException(thread, throwable)` from your new handler"
@@ -195,7 +184,7 @@
195184
errorLine2=" ~~~~~~~~~~~~">
196185
<location
197186
file="src/main/java/in/hridayan/ashell/core/presentation/components/dialog/DialogKey.kt"
198-
line="54"
187+
line="55"
199188
column="15"/>
200189
</issue>
201190

@@ -334,20 +323,6 @@
334323
file="$GRADLE_USER_HOME/caches/9.4.1/transforms/32a81debb4323c0bfda5b8df1a440e9f/transformed/out/jars/classes.jar"/>
335324
</issue>
336325

337-
<issue
338-
id="TrustAllX509TrustManager"
339-
message="`checkClientTrusted` is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers">
340-
<location
341-
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/com.google.http-client/google-http-client/1.46.3/486ca37492048ddd230f5fef65c9411d7b65fb67/google-http-client-1.46.3.jar"/>
342-
</issue>
343-
344-
<issue
345-
id="TrustAllX509TrustManager"
346-
message="`checkServerTrusted` is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers">
347-
<location
348-
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/com.google.http-client/google-http-client/1.46.3/486ca37492048ddd230f5fef65c9411d7b65fb67/google-http-client-1.46.3.jar"/>
349-
</issue>
350-
351326
<issue
352327
id="ObsoleteSdkInt"
353328
message="This folder configuration (`v26`) is unnecessary; `minSdkVersion` is 28. Merge all the resources in this folder into `mipmap-anydpi`.">
@@ -1470,7 +1445,7 @@
14701445
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
14711446
<location
14721447
file="src/main/res/values/strings.xml"
1473-
line="580"
1448+
line="584"
14741449
column="13"/>
14751450
</issue>
14761451

@@ -1481,7 +1456,7 @@
14811456
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
14821457
<location
14831458
file="src/main/res/values/strings.xml"
1484-
line="581"
1459+
line="585"
14851460
column="13"/>
14861461
</issue>
14871462

@@ -1492,7 +1467,7 @@
14921467
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
14931468
<location
14941469
file="src/main/res/values/strings.xml"
1495-
line="582"
1470+
line="586"
14961471
column="13"/>
14971472
</issue>
14981473

app/src/fdroid/java/in/hridayan/ashell/settings/data/repository/FdroidGoogleAuthRepositoryImpl.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package `in`.hridayan.ashell.settings.data.repository
22

3+
import android.content.Context
34
import `in`.hridayan.ashell.settings.domain.model.GoogleUserState
45
import `in`.hridayan.ashell.settings.domain.repository.GoogleAuthRepository
56
import kotlinx.coroutines.flow.MutableStateFlow
@@ -15,7 +16,7 @@ class FdroidGoogleAuthRepositoryImpl @Inject constructor() : GoogleAuthRepositor
1516
private val _googleUserState = MutableStateFlow(GoogleUserState())
1617
override val googleUserState: StateFlow<GoogleUserState> = _googleUserState.asStateFlow()
1718

18-
override suspend fun signIn(): Result<String> =
19+
override suspend fun signIn(context: Context): Result<String> =
1920
Result.failure(UnsupportedOperationException("Google Sign-In is not available in this build."))
2021

2122
override suspend fun signOut() {

0 commit comments

Comments
 (0)