Treasure map names and metadata#12
Open
eakeys wants to merge 9 commits into
Open
Conversation
added 9 commits
April 22, 2026 18:19
…ersion function between treasure map structs
…wine path on non-linux (also now defaults to wibo for faster performance)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some more treasure map related functions: first, the functions that generate the basic metadata - environ, number of floors etc - for regular maps. (It turns out most of the parameters here get read from a binary file, so this was harder to find than I was expecting)
Second, a few functions that generate/store the names of maps. Here the behaviour is very different in the two supported versions. Both versions build with correct assembly, but I'm a bit iffy about the purpose of char buffers & string manipulation functions for the Japanese version.
Speaking of different versions, I had some trouble with the mangler script, as it was compiling the input file without #defining either usa or jpn, so I've modified it to allow passing the version (defaults to usa if unspecified). I also updated it to use the more lightweight wibo tool (which the build script downloads) instead of wine on linux, as I was getting some pretty bad stuttering any time I used it there. It's probably worth checking it still works on machines other than my own