Skip to content

Commit 19235ee

Browse files
authored
Merge pull request #5312 from oscar-escire/Issue/1268
fix: prevent drop files overlay from appearing when dragging text
2 parents bcc1f0e + c276e72 commit 19235ee

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

src/app/shared/upload/file-dropzone-no-uploader/file-dropzone-no-uploader.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@ export class FileDropzoneNoUploaderComponent implements OnInit {
8787

8888
@HostListener('window:dragover', ['$event'])
8989
onDragOver(event: DragEvent) {
90+
// Only show drop area when dragging files or event is manually triggered
91+
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
92+
if (!hasFiles) {
93+
return;
94+
}
9095
// Show drop area on the page
9196
event.preventDefault();
9297
event.stopPropagation();

src/app/shared/upload/uploader/uploader.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,11 @@ export class UploaderComponent implements OnInit, AfterViewInit {
137137
}
138138
}
139139
if (this.enableDragOverDocument && this.dragService.isAllowedDragOverPage()) {
140+
// Only show drop area when dragging files or event is manually triggered
141+
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
142+
if (!hasFiles) {
143+
return;
144+
}
140145
// Show drop area on the page
141146
event.preventDefault();
142147
if ((event.target as any).tagName !== 'HTML') {

0 commit comments

Comments
 (0)