Skip to content

Commit 1ba0fdb

Browse files
fix #5166: add explanation of ORCID iD benefits
1 parent 825b39f commit 1ba0fdb

3 files changed

Lines changed: 21 additions & 0 deletions

File tree

src/app/item-page/orcid-page/orcid-auth/orcid-auth.component.html

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,16 @@ <h1>{{'person.orcid.registry.auth' | translate}}</h1>
8585
<div class="col">
8686
<ds-alert [type]="AlertType.Info">{{ getOrcidNotLinkedMessage() }}</ds-alert>
8787
</div>
88+
</div>
89+
<div class="row mb-3">
90+
<div class="col">
91+
<p data-test="orcid-benefits-description">{{ 'person.page.orcid.benefits.description' | translate }}</p>
92+
<p>
93+
<a data-test="orcid-benefits-learn-more" href="https://info.orcid.org/researchers/#why" target="_blank" rel="noopener noreferrer">
94+
{{ 'person.page.orcid.benefits.learn-more' | translate }}
95+
</a>
96+
</p>
97+
</div>
8898
</div>
8999
<div class="row">
90100
<div class="col">

src/app/item-page/orcid-page/orcid-auth/orcid-auth.component.spec.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,13 @@ describe('OrcidAuthComponent test suite', () => {
178178
fixture.detectChanges();
179179
}));
180180

181+
it('should display orcid benefits description and learn more link', fakeAsync(() => {
182+
const benefitsDescription = fixture.debugElement.query(By.css('[data-test="orcid-benefits-description"]'));
183+
const benefitsLink = fixture.debugElement.query(By.css('[data-test="orcid-benefits-learn-more"]'));
184+
expect(benefitsDescription).toBeTruthy();
185+
expect(benefitsLink).toBeTruthy();
186+
}));
187+
181188
it('should create', fakeAsync(() => {
182189
const orcidLinked = fixture.debugElement.query(By.css('[data-test="orcidLinked"]'));
183190
const orcidNotLinked = fixture.debugElement.query(By.css('[data-test="orcidNotLinked"]'));

src/assets/i18n/en.json5

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4154,6 +4154,10 @@
41544154

41554155
"person.page.orcid": "ORCID",
41564156

4157+
"person.page.orcid.benefits.description": "ORCID is a free, unique, persistent identifier (PID) for individuals to use as they engage in research, scholarship, and innovation activities. It can also help you save time when you use your ORCID to sign into systems like this one.",
4158+
4159+
"person.page.orcid.benefits.learn-more": "Don't have an ORCID iD yet? Learn more at orcid.org",
4160+
41574161
"person.page.staffid": "Staff ID",
41584162

41594163
"person.page.titleprefix": "Person: ",

0 commit comments

Comments
 (0)