fix #4195: update spec and menu provider for subscribe button

Author: guillermo-escire

src/app/shared/menu/providers/comcol-subscribe.menu.spec.ts

@@ -1,48 +1,54 @@
+import { PLATFORM_ID } from '@angular/core';
 import { TestBed } from '@angular/core/testing';
+import { AuthService } from '@dspace/core/auth/auth.service';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
+import { SubscriptionsDataService } from '@dspace/core/data/subscriptions-data.service';
 import { Collection } from '@dspace/core/shared/collection.model';
 import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
+import { TranslateService } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { MenuItemType } from '../menu-item-type.model';
-import { PartialMenuSection } from '../menu-provider.model';
 import { SubscribeMenuProvider } from './comcol-subscribe.menu';
 
 describe('SubscribeMenuProvider', () => {
 
-  const expectedSections: PartialMenuSection[] = [
-    {
-      visible: true,
-      model: {
-        type: MenuItemType.ONCLICK,
-        text: 'subscriptions.tooltip',
-        function: jasmine.any(Function) as any,
-      },
-      icon: 'bell',
-    },
-  ];
-
   let provider: SubscribeMenuProvider;
 
-  const dso: Collection = Object.assign(new Collection(), { _links: { self: { href: 'self-link' } } });
-
+  const dso: Collection = Object.assign(new Collection(), {
+    uuid: 'mock-uuid',
+    _links: { self: { href: 'self-link' } },
+  });
 
   let authorizationService;
   let modalService;
+  let authService;
+  let subscriptionsDataService;
 
   beforeEach(() => {
-
     authorizationService = jasmine.createSpyObj('authorizationService', {
-      'isAuthorized': of(true),
+      isAuthorized: of(true),
     });
 
     modalService = jasmine.createSpyObj('modalService', ['open']);
 
+    authService = jasmine.createSpyObj('authService', {
+      getAuthenticatedUserFromStore: of({ id: 'mock-user-id' }),
+    });
+
+    subscriptionsDataService = jasmine.createSpyObj('subscriptionsDataService', {
+      getSubscriptionsByPersonDSO: of({ payload: { page: [] } }),
+    });
+
     TestBed.configureTestingModule({
       providers: [
         SubscribeMenuProvider,
         { provide: AuthorizationDataService, useValue: authorizationService },
         { provide: NgbModal, useValue: modalService },
+        { provide: AuthService, useValue: authService },
+        { provide: SubscriptionsDataService, useValue: subscriptionsDataService },
+        { provide: TranslateService, useValue: {} },
+        { provide: PLATFORM_ID, useValue: 'browser' },
       ],
     });
     provider = TestBed.inject(SubscribeMenuProvider);
@@ -53,13 +59,32 @@ describe('SubscribeMenuProvider', () => {
   });
 
   describe('getSectionsForContext', () => {
-    it('should return the expected sections', (done) => {
-      provider.getSectionsForContext(dso).subscribe((sections) => {
-        expect(sections).toEqual(expectedSections);
-        done();
-      });
+    it('should return subscribe section when user has no subscription', (done) => {
+      provider.getSectionsForContext(dso)
+        .pipe()
+        .subscribe((sections) => {
+          if (sections.length > 0 && sections[0].visible) {
+            expect(sections[0].model.type).toBe(MenuItemType.ONCLICK);
+            expect((sections[0].model as any).text).toBe('subscriptions.tooltip');
+            expect(sections[0].icon).toBe('bell');
+            done();
+          }
+        });
     });
-  });
 
+    it('should return manage subscription section when user is already subscribed', (done) => {
+      subscriptionsDataService.getSubscriptionsByPersonDSO.and.returnValue(
+        of({ payload: { page: [{ id: 'sub-1' }] } }),
+      );
 
+      provider.getSectionsForContext(dso)
+        .pipe()
+        .subscribe((sections) => {
+          if (sections.length > 0 && sections[0].visible) {
+            expect((sections[0].model as any).text).toBe('subscriptions.manage');
+            done();
+          }
+        });
+    });
+  });
 });

src/app/shared/menu/providers/comcol-subscribe.menu.ts

@@ -11,8 +11,10 @@ import {
   Injectable,
   PLATFORM_ID,
 } from '@angular/core';
+import { AuthService } from '@dspace/core/auth/auth.service';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '@dspace/core/data/feature-authorization/feature-id';
+import { SubscriptionsDataService } from '@dspace/core/data/subscriptions-data.service';
 import { DSpaceObject } from '@dspace/core/shared/dspace-object.model';
 import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateService } from '@ngx-translate/core';
@@ -29,10 +31,8 @@ import {
   startWith,
   switchMap,
 } from 'rxjs/operators';
-import { AuthService } from '@dspace/core/auth/auth.service';
 
 import { SubscriptionModalComponent } from '../../subscriptions/subscription-modal/subscription-modal.component';
-import { SubscriptionsDataService } from '@dspace/core/data/subscriptions-data.service';
 import { OnClickMenuItemModel } from '../menu-item/models/onclick.model';
 import { MenuItemType } from '../menu-item-type.model';
 import { PartialMenuSection } from '../menu-provider.model';