Search service suggestion tests

Author: strawburster

src/app/shared/search/search.service.spec.ts

@@ -146,6 +146,45 @@ describe('SearchService', () => {
     });
   });
 
+  describe('getSuggestionsFor', () => {
+    let remoteDataMocks: Record<string, RemoteData<any>>;
+    let dictionary = 'supermodels';
+    let query = 'strawburster';
+
+    beforeEach(() => {
+      remoteDataMocks = {
+        RequestPending: new RemoteData(undefined, msToLive, remoteDataTimestamp, RequestEntryState.RequestPending, undefined, undefined, undefined),
+        ResponsePending: new RemoteData(undefined, msToLive, remoteDataTimestamp, RequestEntryState.ResponsePending, undefined, undefined, undefined),
+        Success: new RemoteData(remoteDataTimestamp, msToLive, remoteDataTimestamp, RequestEntryState.Success, undefined,
+          { suggest: { [dictionary]: { [query]: ['strawburster', 'lesser', 'known', 'people'] } } },
+          200),
+        SuccessStale: new RemoteData(remoteDataTimestamp, msToLive, remoteDataTimestamp, RequestEntryState.SuccessStale, undefined, new SearchObjects(), 200),
+      };
+    });
+
+    it('should call getEndpoint on the halService with the suggest endpoint', () => {
+      spyOn(halService, 'getEndpoint').and.callThrough();
+
+      service.getSuggestionsFor(dictionary, query).subscribe();
+
+      expect(halService.getEndpoint).toHaveBeenCalledWith('discover');
+    });
+
+    it('should send out the request on the request service', () => {
+      service.getSuggestionsFor(dictionary, query).subscribe();
+
+      expect(requestService.send).toHaveBeenCalled();
+    });
+
+    it('should call buildFromUUID on the request service', () => {
+      spyOn(remoteDataBuildService, 'buildFromRequestUUID').and.callThrough();
+
+      service.getSuggestionsFor(dictionary, query).subscribe();
+
+      expect(remoteDataBuildService.buildFromRequestUUID).toHaveBeenCalled();
+    });
+  });
+
   describe('search', () => {
     let remoteDataMocks: Record<string, RemoteData<SearchObjects<any>>>;
 

src/app/shared/search/search.service.ts

@@ -147,7 +147,7 @@ export class SearchService {
     }
   }
 
-  getSuggestEndpoint(searchOptions?: PaginatedSearchOptions): Observable<string> {
+  getDiscoverEndpoint(searchOptions?: PaginatedSearchOptions): Observable<string> {
     // TODO: HAL link to 'suggest' endpoint does not exist yet, need to fix this
     return this.halService.getEndpoint('discover').pipe(
       map((url: string) => {
@@ -359,7 +359,7 @@ export class SearchService {
    * @returns serialised JSON of Solr term suggestions
    */
   getSuggestionsFor(query: string, dictionary: string): Observable<SuggestionEntry[]> {
-    return this.getSuggestEndpoint().pipe(
+    return this.getDiscoverEndpoint().pipe(
       take(1),
       switchMap((baseUrl: string) => {
         const href = new URLCombiner(baseUrl, 'suggest').toString();
@@ -375,12 +375,16 @@ export class SearchService {
         this.requestService.send(request, false);
         return this.rdb.buildFromRequestUUID(request.uuid).pipe(
           getFirstSucceededRemoteDataPayload(),
-          map((data: any) => data.suggest[dictionary][query].suggestions
-            ?.map(((suggestion: any) => new SuggestionEntry(
-              new DOMParser().parseFromString(suggestion.term, 'text/html')
-                .body.textContent,
-              this.sanitizer.bypassSecurityTrustHtml(suggestion.term),
-              suggestion.weight)))));
+          map((data: any) => {
+            if (data.suggest && data.suggest[dictionary] && data.suggest[dictionary][query]?.suggestions) {
+              return data.suggest[dictionary][query].suggestions
+                .map(((suggestion: any) => new SuggestionEntry(
+                  new DOMParser().parseFromString(suggestion.term, 'text/html')
+                    .body.textContent,
+                  this.sanitizer.bypassSecurityTrustHtml(suggestion.term),
+                  suggestion.weight)));
+            }
+          }));
       }));
   }