Skip to content

Commit 511bc9d

Browse files
authored
Merge pull request #5727 from DSpace/backport-5312-to-dspace-8_x
[Port dspace-8_x] fix: prevent drop files overlay from appearing when dragging text
2 parents e018998 + f3b9e53 commit 511bc9d

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

src/app/shared/upload/file-dropzone-no-uploader/file-dropzone-no-uploader.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@ export class FileDropzoneNoUploaderComponent implements OnInit {
9090

9191
@HostListener('window:dragover', ['$event'])
9292
onDragOver(event: DragEvent) {
93+
// Only show drop area when dragging files or event is manually triggered
94+
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
95+
if (!hasFiles) {
96+
return;
97+
}
9398
// Show drop area on the page
9499
event.preventDefault();
95100
event.stopPropagation();

src/app/shared/upload/uploader/uploader.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,11 @@ export class UploaderComponent implements OnInit, AfterViewInit {
124124
onDragOver(event: any) {
125125

126126
if (this.enableDragOverDocument && this.dragService.isAllowedDragOverPage()) {
127+
// Only show drop area when dragging files or event is manually triggered
128+
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
129+
if (!hasFiles) {
130+
return;
131+
}
127132
// Show drop area on the page
128133
event.preventDefault();
129134
if ((event.target as any).tagName !== 'HTML') {

0 commit comments

Comments
 (0)