Skip to content

Commit 5655971

Browse files
committed
Improved validation to prevent Cypress (and manual triggers) failing
1 parent 2bf7ed8 commit 5655971

4 files changed

Lines changed: 8 additions & 4 deletions

File tree

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ package-lock.json
3535

3636
.java-version
3737

38-
.env
3938
/nbproject/
4039

4140
junit.xml
4241

4342
/src/mirador-viewer/config.local.js
43+
config.bat

postcss.config.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/app/shared/upload/file-dropzone-no-uploader/file-dropzone-no-uploader.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ export class FileDropzoneNoUploaderComponent implements OnInit {
6464
@HostListener('window:dragover', ['$event'])
6565
onDragOver(event: any) {
6666
// Only show drop area when dragging files, not text selections (fixes Firefox bug)
67-
if (!event.dataTransfer?.types?.includes('Files')) {
67+
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
68+
69+
if (!hasFiles) {
6870
return;
6971
}
7072
// Show drop area on the page

src/app/shared/upload/uploader/uploader.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ export class UploaderComponent {
8888

8989
if (this.enableDragOverDocument && this.dragService.isAllowedDragOverPage()) {
9090
// Only show drop area when dragging files, not text selections (fixes Firefox bug)
91-
if (!event.dataTransfer?.types?.includes('Files')) {
91+
const hasFiles = event.dataTransfer?.types ? Array.from(event.dataTransfer.types).includes('Files') : true;
92+
93+
if (!hasFiles) {
9294
return;
9395
}
9496
// Show drop area on the page

0 commit comments

Comments
 (0)